GithubHelp home page GithubHelp logo

Comments (3)

shawn-simon avatar shawn-simon commented on August 22, 2024 6
#!/bin/bash

git stash -q --keep-index

branch=$(git symbolic-ref HEAD | sed -e 's,.*/\(.*\),\1,')

if [ "$branch" ==  "master" ]; then
    echo 'Commit on master: Running jshint on entire depo.'
    $(npm bin)/jshint .

else
    echo 'Commit on non-master branch: Running jshint on current changeset.'
    git diff-index --cached HEAD --name-only --diff-filter ACMR | egrep '.js$' | xargs $(npm bin)/jshint
fi

RESULT=$?

git stash pop -q

[ $RESULT -ne 0 ] && exit 1
exit 0

final script we went with for future googlers

from pre-commit.

mroderick avatar mroderick commented on August 22, 2024

Is there a way to configure this to only run the commit hooks on master?

That seems like a really bad idea. You'll want to verify things as early as possible. By the time things get to master they should be clean.

I supposed this is related to #50, check out the script to only verify staged changes.

from pre-commit.

shawn-simon avatar shawn-simon commented on August 22, 2024

Yes, it was more because of the performance issue- the scripts taking so long to run. I think I'll make it so on master it forces to run on the whole repo, but outside of the branch, only on staged changes. I'll figure it out from here. Thanks again!

from pre-commit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.