Migration to version 8.0/9.0 about connector-prestashop

[guewen]

@flotho as soon as the V8 one is published, I'll start to work on the V9 one. I have nothing against pushing a temporary working branch on which we merge each ones pull requests optimistically, if the PSC does not have any issue with that.

[pedrobaeza]

I'm doing today!

[guewen]

I'd would be glad to have a link to the branch if there is any :)

I'd like to propose a slightly different layout for the models (in fact, more an extension) than the usual one for this migration. This is a layout I used for my lasts custom connectors and it works well when we have a lot of classes for a model (we have, in the connectors):

connector_xyz
├── data
├── __init__.py
├── models
│   ├── __init__.py
│   ├── product_category
│   │   ├── common.py
│   │   ├── exporter.py
│   │   ├── importer.py
│   │   └── __init__.py
│   ├── product_product
│   │   ├── common.py
│   │   ├── exporter.py
│   │   ├── importer.py
│   │   └── __init__.py
│   ├── product_template
│   │   ├── common.py
│   │   ├── exporter.py
│   │   ├── importer.py
│   │   └── __init__.py
│   ├── sale_order
│   │   ├── common.py
│   │   ├── exporter.py
│   │   ├── importer.py
│   │   └── __init__.py
│   └── sale_order_line
│       ├── common.py
│       ├── exporter.py
│       ├── importer.py
│       └── __init__.py
└── views

common.py contains the openerp.models.Model definition/inherit and the things which are common to both the importer and the exporter (Binder, Adapter), the other files speak by themselves. Of course, you can have more or less files for a model.

[gurneyalex]

I just sent an email to the contributors mailing list to try and get some fresh blood on this project

[ajile-in]

Hi @pedrobaeza ,

I would like to contribute to this activity, please let me know how can I help.

Regards,
Ajay

[pedrobaeza]

Hi, you can take the current work that is across the PRs and try to get it work, but for v9 is still too soon, because there is a lot of dependencies not migrated (connector, sale-workflow...). Maybe you can try in v8, and then let this prepared for v9.

[flotho]

Hi @Ajaeel , @pedrobaeza

I also would like to migrate this part in V9.
Actually I'm wondering how to deal with sale workflow. As you probably know, Odoo v9 has no more workflow on sale.order.
@pedrobaeza What are you recommendations? re-implement the Odoo v8 part or try to make it lighter ?
regards

[atchuthan]

@Ajaeel @flotho ongoing discussion at OCA mailing list
https://odoo-community.org/groups/contributors-15/contributors-37353?

[NVD77]

I understand that this is about connecting PrestaShop with ODOO version 9. May I ask if the connector to version 8 was already finished?

[pedrobaeza]

This issue was automatically generated. Indeed, v8 nor v9 is yet migrated.

[NVD77]

Thanks for your quick feedback! Is there any ongoing progress? Our ODOO consultant was looking on github for others to work together to migrate to version 8 yet no sufficient reply. Since we upgraded the erp to v8 we can't set up a synchronization with our PrestaShop 1.6 site.

[pedrobaeza]

Not for now, but we will propose the migration in the next months

[dalareo]

I have proposed a Prestashop-Odoo solution to one of my clients but... no connector available! He is very interested and a little financial effort will also be possible to have this done! I don't have the python knowledge enough to help you on this, @pedrobaeza
V8 alone will be nice for me right now.

[flotho]

Hi @dalareo, this branch https://github.com/flotho/connector-prestashop/tree/8.0-parthiv-mig has been the most advanced try for porting in v8. @parthivgls has done a great job and I personnaly add some functionnality.
Sadly, it hasn't been merged (optimistic merged would have been appreciated here) in the official OCA.
regards

[dalareo]

Thanks @flotho! I am waiting for v9 to be available as it is the version my customers are using now!

[guewen]

Anyone started to work on the migration for v9? I plan to start working on it soon, so I'd want to avoid double work.

[parthivgls]

me me me .... 💯 but first connector-ecoomerce to be completed..

[pedrobaeza]

@atchuthan is also working in the migration to v9 AFAIK.

[pedrobaeza]

We will release the migration to version 8 on September, with a total rework. I think you can wait until then and see our work, and then talk about it. What do you think?

[pedrobaeza]

About the layout itself, isn't too many files? Having into account that the exporter is implemented in a separated module...

[guewen]

@pedrobaeza no there are not too many files when you have a lot of classes. When I open a Python module and I see a long list of classes, with mappers, exporters, importers and so on all mixed, the only thing I think is "What a mess!". Trust me, through all the connectors I developed since years, the layout above is the result of a process to find the ideal solution. For the custom connectors I developed with that layout, I would never ever return back to a style where you have all mixed.

@pedrobaeza is your rework public? Even before all is done, I could start to work on something and assume doing some rebase at times :) Do you still use prestapyt which is hardly maintained (and if yes, did you need to modify it?)?

[pedrobaeza]

As said, it's going to be released on September (next week) as a PR here. Yes, we use prestapyt. In fact, you have a PR to approve 😉 : prestapyt/prestapyt#34.

Maybe we can transfer the repository to OCA.

OK about the files. You're right that we can isolate each class in a file, following OCA's guidelines.

[guewen]

@pedrobaeza okay, thanks

I merged the prestapyt PR

[guewen]

Did anyone had a look at https://github.com/openlabs/pystashop? It looks better than prestapyt IMO (as the prestapyt author, I'm allowed to say that :)). When I wrote prestapyt, working with dicts was a requirement, that's why it converts to and back from dictionaries, nowadays, making the connector's Mapper agnostic to the format would be great anyway.

[pedrobaeza]

I didn't know, but I don't have a very good feeling surrogating part of our needs to a library from OpenLabs. I remember bad experiences in the past from contributors with the Magento library. Am I wrong?

[guewen]

We use the magento python lib from OpenLabs for the Magento connector and I'm not aware of any issues, had patch(es?) merged. Also, it's open source, we would not be depending on anyone if things would go wrong.

[pedrobaeza]

OK, if you want to take a look for version 9, go ahead. We have already working everything in version 8, so now switching is a work we can't afford.

[guewen]

Absolutely, I never thought you would change for v8.0 now. I'm also not saying we should use it, but I'll evaluate the option.

[flotho]

@guewen , great news for the layout,
I'm not so experienced in connector framework and the prestashopconnector is really a mess for someone who tried to understand how the classes are structured.
So I really would like to cooperate on this all the more so as I've already started some migration https://github.com/flotho/connector-prestashop/
My point is how to cooperate fast? Could it be interesting to start the famous optimistic merge on a dedicated branch?
@gaelTorrecillas and I would like to give some time on this as we need this migration fast. Does anyone could propose a way to split/distribute the job?
Regards

[flotho]

Hi @sebastienbeau , @guewen , @pedrobaeza ,

Could anyone take the leadership on this migration, we really would like to contribute actively.
regards

[flotho]

@gurneyalex , thanks
@gaelTorrecillas and I would appreciate to give our fresh blood on this ;-)

[guewen]

@pedrobaeza when do you expect to push? Sorry if I'm insistent, but I have time on my planning today and tomorrow to kick off the 9.0 migration. Nobody will blame you if the branch is not perfect yet :)

[guewen]

@pedrobaeza any review I can do on prestashop connector's dependency addons?

[guewen]

@pedrobaeza yeaah, looking forwards to it :)

[flotho]

Hi @pedrobaeza,

Great thanks for your PR on v8 migration with newer PS versions. We'll take care of that part.

[flotho]

Hi @guewen , @pedrobaeza ,

Did you decided to have an optimistic PR for the v9 migration. I have 1.5 devs available for the next 2 weeks and really would like to help on this.
Regards
cc @gaelTorrecillas

[guewen]

@flotho my working branch is there: https://github.com/guewen/connector-prestashop/tree/9.0-migration-connector-prestashop

I'm working on the reorganization of the files, which must be done before we can work at more than one person at a time.

[flotho]

Hi @guewen ,

If you agree, we're going to work on this with @gaelTorrecillas. regards

[gaelTorrecillas]

Hi @guewen,

In original openerp of connector-prestashop, this module depended on product_custom_attributes,
what replaces it here? will you replace it with product_custom_info?

[pedrobaeza]

@gaelTorrecillas, that's not needed. Any specific PrestaShop information is put directly on the prestashop.product.product model (the binding).

[gaelTorrecillas]

hi,

@pedrobaeza thank you for your answer,

@guewen, where are you with the connector prestashop migration? and do you have part on which we can work to avoid overlap with your work?

[guewen]

@gaelTorrecillas look at the description of the issue, I added some tasks, you can see my progress as I tick the boxes. I'm working on the "payment method to account.payment.mode" task. Choose a task you would be comfortable to work on, the list is not exhaustive you might have other things to do. If you'll need the "catalog" module, you could also work on it as I didn't even started.

[guewen]

@gaelTorrecillas could you comment on the pull request #24 ?

[gaelTorrecillas]

yes,
sorry, I'm not on the right topic

[pedrobaeza]

As the connector is now merged, we can close this tracking issue. Thank you to all the contributors.