GithubHelp home page GithubHelp logo

Comments (11)

alexis-via avatar alexis-via commented on August 16, 2024 1

@StefanRijnhart OK, I understand the reason. I think we can add this feature directly in the account_invoice_import_invoice2data module.

from edi.

hbrunn avatar hbrunn commented on August 16, 2024

did you see https://github.com/OCA/edi/pull/21/files#diff-dacb319278273b6cbb1e56ab74bf3952R5 where I slipped in the module invoice2data_template? As the customer we made that for switched to a different product, I won't be developing this further, so you're welcome to yank from there what you need if it fits for you

from edi.

StefanRijnhart avatar StefanRijnhart commented on August 16, 2024

Ooh pretty! Thank you.

from edi.

alexis-via avatar alexis-via commented on August 16, 2024

@StefanRijnhart What advantage would you get in storing invoice2data templates in the DB rather than on the filesystem ? The ability for the user without access to the FS to add/modify an invoice2data template ? Another reason ?

from edi.

StefanRijnhart avatar StefanRijnhart commented on August 16, 2024

@alexis-via The reason is because sharing a directory with the Odoo server is never easy, and in my case it's not even allowed as per project policy. Plus you get all the benefit of managing the templates in the same systems as in which they are used, and Odoo access control and audit logging.

But if you don't see the benefit we will take Holger's work and use it as a customization in our system rather than pushing a PR.

from edi.

pedrobaeza avatar pedrobaeza commented on August 16, 2024

I like your idea, @StefanRijnhart

from edi.

StefanRijnhart avatar StefanRijnhart commented on August 16, 2024

If we want to do this in the least disruptive way, we do not introduce a new dependency in account_invoice_import_invoice2data in a stable version, but we check at runtime if the module is installed and check any database templates in that case (in addition to the templates on the filesystem). When migrating this module to a new version, the explicit dependency can be added (add a comment about this in the module). Do you agree with this strategy?

from edi.

pedrobaeza avatar pedrobaeza commented on August 16, 2024

OK for me.

from edi.

StefanRijnhart avatar StefanRijnhart commented on August 16, 2024

OK, thanks! I'll add it to the ticket in our backlog to create a PR for this.

from edi.

github-actions avatar github-actions commented on August 16, 2024

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

from edi.

StefanRijnhart avatar StefanRijnhart commented on August 16, 2024

Closing as there are PRs

from edi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.