GithubHelp home page GithubHelp logo

Comments (4)

ocornut avatar ocornut commented on June 12, 2024

The behaviour of other programs is more of a cut-off at exactly 500 letters

I don't think many other programs have limitations?
More often a real application would wrap InputText() to use std::string or their own string type, as shown e.g. https://github.com/ocornut/imgui/blob/master/misc/cpp/imgui_stdlib.h
Are you sure you simply don't want to do that?

Or you want to actually benefit from the clamped pasting?

from imgui.

Infiziert90 avatar Infiziert90 commented on June 12, 2024

My case requires a hard limit of 500 characters, so for me clamping is the bigger benefit

User can still paste their text without the text box just staying blank the moment it goes above 500

from imgui.

ocornut avatar ocornut commented on June 12, 2024

The ideal fix would requires reworking how calls to STB_TEXTEDIT_INSERTCHARS() are handled:

  • main meaningful one in stb_textedit_paste_internal() in imstb_textedit.h.
  • one in stb_textedit_replace() in imgui_widgets.cpp which is in theory cannot fail in normal condition (it would fail if user change underlying static buffer between activation and revert).
    But it probably means breaking stb_textedit.h API.

Another strategy which seems simpler if we perform a clamped call to stb_textedit_paste() directly in our handler, and only in the case where the buffer is not resizable.

from imgui.

ocornut avatar ocornut commented on June 12, 2024

One thing that makes me uneasy about clamping the pasted contents is if you paste from beginning or middle of an existing thing, then your pasted content would be cut off but the cut off is likely to be less visible.

from imgui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.