GithubHelp home page GithubHelp logo

Comments (6)

ypujante avatar ypujante commented on June 12, 2024 1

@CallumFerguson I am currently working on a PR to use a different implementation of glfw with emscripten. One of the changes is to get rid of the mouse wheel callback in ImGui since the new implementation takes care of it.

I definitely can reproduce the problem with the build BEFORE my PR (https://pongasoft.github.io/imgui/pr-7520/imgui-master-b720c0f/). But I can see that the build AFTER my PR does not have this issue (https://pongasoft.github.io/imgui/pr-7520/ypujante-master-fd249f9/). So it looks like my new glfw implementation does the "right" thing in regards to mousewheel.

Could you confirm on your end that the problem goes away with the PR (by trying this demo)? (note that on macOS Firefox does not support webgpu yet so it requires Chrome, looks like you are on Windows and I believe it works fine there).

@ocornut I apologize for the delay in submitting the final PR: emscripten has been slow in releasing the needed version and then I am currently away on vacation and prefer to wait until I return (in a couple weeks) instead of trying to do a push from my laptop thousands of miles away...

from imgui.

CallumFerguson avatar CallumFerguson commented on June 12, 2024 1

I tried your demos. I can see the warning on the build before the PR, and I do not see the warning on the build after the PR.

from imgui.

ypujante avatar ypujante commented on June 12, 2024 1

As promised, I did fix this bug part of the PR. See #7647.

Turns out that using the document as the target of the event was the cause of the issue. Using the canvas selector instead addresses the issue.

from imgui.

ocornut avatar ocornut commented on June 12, 2024

Maybe @ypujante would know?

from imgui.

ocornut avatar ocornut commented on June 12, 2024

As discussed in said PR, it is likely we'd want to keep support for both, so it would be good to fix that particular warning either way.

Enjoy your holidays!

from imgui.

ypujante avatar ypujante commented on June 12, 2024

@ocornut Got it. I will make sure that the old path does not have the warning anymore when I submit the PR. I still would like to confirm that @CallumFerguson does not see the warning with the new code.

from imgui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.