Support AXFR/RF2136 to Azure Private DNS about octodns-bind

[ross]

Going to move this into https://github.com/octodns/octodns-bind since it appears to be specific to that provider.

[ross]

What version of the AzureProvider are you using, it looks like it should support ROOT_NS values https://github.com/octodns/octodns-azure/blob/70b8c9153db8ee25e701a5b488f828560f536156/octodns_azure/__init__.py#L903, though there may be some complications around Azure's requiring its own NS values to be included.

Beyond that based on a quick look at the error message it appears to be something that the underlying library throws and not octoDNS,

octodns-bind/tests/test_provider_octodns_bind.py

Line 131 in a6fb996

'The DNS zone has no NS RRset at its origin.', str(ctx.exception)

, https://github.com/octodns/octodns-bind/blob/a6fb996c4bdd5661374a8ab0cc8bc21fe54dff6f/tests/zones/invalid.zone.tst.

Based on 👁️ing the underlying library's code, https://dnspython.readthedocs.io/en/latest/_modules/dns/zone.html?highlight=from_file# and https://dnspython.readthedocs.io/en/latest/_modules/dns/zone.html?highlight=from_xfr# both state they throw that error and don't appear to have a way to suppress it.

Side note: I'd recommend pasting the stack traces in addition to the specific exception messages as it can be helpful when digging into where errors are coming from.

[ross]

Hrm, actually looks like check_origin https://dnspython.readthedocs.io/en/latest/_modules/dns/zone.html?highlight=check_origin# throws that error and there may be an argument to the calls that controls whether or not that happens. If that's the case then it's possible a provider arg check_origin would make sense.

[benjamin-rousseau-shift]

I'm talking specifically about Azure Private DNS Zone which is provider AzurePrivateProvider. ( Latest version ).

It does not support NS, but I'm wondering if there might be a workaround for usecases where we want to sync a axfr/rfc zone to an Azure private DNS zone.

I'm out of office now but I can give more details tomorrow if needed. 👍

[ross]

It does not support NS, but I'm wondering if there might be a workaround for usecases where we want to sync a axfr/rfc zone to an Azure private DNS zone.

You can disable strict_supports to turn that supports exception into a warning, https://github.com/octodns/octodns#strict_supports-work-in-progress. You need to make sure that's the only warning that's printed out afterwards or that you're OK with any others.

[benjamin-rousseau-shift]

You are correct it's working fine with strict_supports disabled !
Thank you so much.

I would then suggest that the error thrown, tell you about this with a link to the right section in the README.