Comments (5)
good questions, I should have been more clear. It was a question by someone who wanted to send a pull request to @octokit/rest
documentation but didn't understand the commit conventions. If it was clear that these are only relevant to maintainers then the problem would not have occured.
I think I would add a new header ## Maintainers only
here:
create-octokit-project.js/lib/create-contributing.js
Lines 62 to 77 in 51f5a55
and then make the current heading level 3: ### Merging the Pull Request & releasing a new version
. That should be clear enough?
from create-octokit-project.js.
I'd PR it in this case, because this is such a meta repository
from create-octokit-project.js.
What was the issue with this? (any confusion with contributors so it is needed to improve this description?), also, what do you have in mind? Just highlighting a disclaimer for that section saying is for maintainers only?
from create-octokit-project.js.
good questions, I should have been more clear. It was a question by someone who wanted to send a pull request to
@octokit/rest
documentation but didn't understand the commit conventions. If it was clear that these are only relevant to maintainers then the problem would not have occured.I think I would add a new header
## Maintainers only
here:create-octokit-project.js/lib/create-contributing.js
Lines 62 to 77 in 51f5a55
and then make the current heading level 3:
### Merging the Pull Request & releasing a new version
. That should be clear enough?
Yep. I guess this a goodfirstissue
, should we leave it? Or just PR it?
from create-octokit-project.js.
🎉 This issue has been resolved in version 1.9.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from create-octokit-project.js.
Related Issues (20)
- Create "main" as default branch, instead of "master"
- The automated release is failing 🚨 HOT 1
- add `@octokit/core` as peer dependency
- Create projects with @octokit/tsconfig HOT 1
- [Discussion] Update octokit project HOT 3
- Dependency Dashboard
- add renovate configuration to Repository if repository is in @octokit HOT 11
- add deep links to install apps links in pull request description HOT 3
- Run `dependency-check` in Test Action Workflow HOT 1
- "What is the main export of the module?" A module can have multiple exports
- Action Required: Fix Renovate Configuration
- 404 for GET /orgs HOT 3
- Bug: Error on npm init HOT 8
- Rewrite as ESM module HOT 1
- Add renovate configuration if owner is 'octokit' HOT 1
- Device flow is disabled for the app id HOT 2
- [BUG]: Generated test workflow incorrectly uses `always` HOT 3
- [BUG]: Incorrect github token name used in update-prettier.yml workflow HOT 1
- [MAINT]: Update npm token instructions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-octokit-project.js.