GithubHelp home page GithubHelp logo

Comments (5)

seanadkinson avatar seanadkinson commented on May 19, 2024

Yeah, I've known that was a little silly to have in there for awhile, since if someone wasn't using express, they'd get the whole package.

I think if we move it to optionalDependencies, it should not be automatically downloaded, but still have a version constraint if it is there. I'll try to throw up a branch with that so that you can give it a try.

from react-s3-uploader.

clarkie avatar clarkie commented on May 19, 2024

I've just had a look at this and optionalDependencies are automatically installed by default so it doesn't help unless you use the --no-optional flag when running npm install.

It doesn't feel like there's a nice solution to this. I wonder which is the most common version of npm in use? v2 or v3?

I think the biggest value of this module is the react component and lifecycle bit. Generating the signed url is the easy bit. It might be worth removing the express section completely and just improving the docs to explain what's required from the user's backend.

What do you think?

from react-s3-uploader.

seanadkinson avatar seanadkinson commented on May 19, 2024

Could also just remove the dependency altogether, since someone who is using express will naturally already have the dependency specified elsewhere. Then if you aren't using express and never import the router, it wouldn't be a problem.

from react-s3-uploader.

clarkie avatar clarkie commented on May 19, 2024

see #53. Let me know what you think

from react-s3-uploader.

seanadkinson avatar seanadkinson commented on May 19, 2024

Merged #53 and published v2.0.0 with this change. Thanks!

from react-s3-uploader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.