New account gives "can't be blank" for filled-in password about ex_venture

[nomicflux]

Aha - the problem was that my username had a space in it, and the hashing code in lib/data/user.ex requires a valid changeset:

  defp hash_password(changeset) do
    case changeset do
      %{valid?: true, changes: %{password: password}} ->
        put_change(changeset, :password_hash, Comeonin.Bcrypt.hashpwsalt(password))

      _ ->
        changeset
    end
  end

Verified that changing the username to a valid one removes the password error.

[nomicflux]

This appears to be related to hashing; changing the line

        <%= error_tag f, :password_hash %>

to

        <%= error_tag f, :password %>

in web/templates/registration/new.html.eex allows the account to be created after fixing other validation errors.

[oestrich]

Hmm, I was able to make an account locally without issue. Did your passwords match? It might be that along with what you just found. I was able to get the proper warnings with a miss-match.

[nomicflux]

Any ideas on the best way of going about improving this? The error message is misleading, but there isn't much sense in hashing the password until creating the user, either. Should the template just show errors for :password under that field, and throw more serious errors about a server-side problem if :password_hash is problematic?

[oestrich]

Yeah I'm not sure. Might be worth switching the password field to using error_tag(f, :password). Might be some other small tweaks that need to happen but this is a good start.