build with gcc on mac hits abs error about stockfish

[UniQP]

1. Can you share the compile command as well (so we know the used compiler flags)?
2. There seems to be some code missing in your proposed changes. Can you surround the code by single (or triple) backticks?
3. Does adding a #include <cstdlib> in nnue/evaluate_nnue.cpp fixes the error?
4. Independent of the error: Are you using x86-based or arm-based hardware? In latter case, you should consider using a different architecture (ARCH=apple-silicon).

[snicolet]

@atalkingegg
Thanks for the report!

Does it remove the compile error if you change line 254 of evaluate_nnue.cpp to the following?

    const double pawns = std::abs(double(0.01) * UCI::to_cp(v));

[atalkingegg]

For some reason the original post removed the important part of the patch, include cmath with the appropriate cpp punctuation around it.
I pulled that include out, and replaced 254 with snicolet's line, and no it still gets that original error.
I then added the include cstdlib line that UniQP suggested, and it still has the same error.
To UniQP's question, "make build ARCH=x86-64-sse41-popcnt", and yes it's an intel based mac.
It also works with snicolet's version const double pawns line and the original version include cmath (not including cstdlib)

Hopefully this all gets through the filter and is understandable.
Thanks!

[atalkingegg]

I just tried the original version of line 254, and only the new include cmath, and it also works. That would be the minimal fix for this issue.

[atalkingegg]

I just pulled the latest git origin/master version, the build problem still exists, but the include cmath fix still works. Please add. Thanks!

[UniQP]

I would still be interested in the compiler command for nnue/evaluate_nnue.cpp as I could not reproduce the problem.

[snicolet]

I just tried the original version of line 254, and only the new include cmath, and it also works. That would be the minimal fix for this issue.

If you have a github account, could you open a pull request with this minimal fix? thanks :-)

[snicolet]

@atalkingegg Can you confirm the 3c0e86a fixed the issue for your compilation problem? :-)