copying deep instance with relationships does not behave as expected about ember-data-copyable

In further testing, this happens with a parent child relationship as well.

[offirgolan]

Okay after some debugging, I figured out what is going on!

The model is not actually being overwritten. The issue spans from Ember Data's implicit inverse relationship setup. Pretty much, when we do a copy by reference of a child model which has an inverse, it no longer belongs to the original model. The child now belongs to the copy. That is why you see all the child relationships disappear when you click on copy.

One thing you can do is just add inverse: null to the House's windows property:

// models/house.js
export default Model.extend(Copyable, {
  address: attr(),
  window: hasMany('window', { inverse: null })
});

All in all, this is an ember data issue and not something that I can control from within this addon.

Thanks for diagnosing this further. I can look at configuring it to not have this explicit inverse, or just traverse the relationship tree and copy each. In case I wanted to keep the inverse relationship, is there a way to deep copy relationships so it is not by reference?

[offirgolan]

No problem at all! It was an interesting problem to debug.

To be able to deep copy a child relationship, the Copyable mixin must be on the child model(s). After you do that, it should work out of the box.

Excellent, thanks again!