GithubHelp home page GithubHelp logo

Comments (6)

pixelpanik avatar pixelpanik commented on May 23, 2024 2

Ahhh. No, didn't set this to active. Thought this would mean that the cookie is always active (even without giving consent). Maybe I was misleaded by the copy "Have turned on at Start-up. This cookie is enabled by default".

So now it's working as excepted. Solution only one click ;) Thank you very much Tobias. Really appreciated and keep up the good work.

from oc-gdpr-plugin.

tobias-kuendig avatar tobias-kuendig commented on May 23, 2024

This looks like your updatePartial and updateSelector values are wrong. Check what is in those variables:

https://github.com/OFFLINE-GmbH/oc-gdpr-plugin/blob/develop/components/cookiebanner/optin.htm#L8

Defaults:

[cookieBanner]
include_css = 1
update_partial = "gdpr"
update_selector = "#gdpr-reload"

from oc-gdpr-plugin.

pixelpanik avatar pixelpanik commented on May 23, 2024

Thanks for the quick reply.

updatePartial and updateSelector should be ok.

When I activate the flag "Required for the Website to Function and Work" in my cookie group, the code in the conditional in the gdpr partial is shown (which is odd as we do not want a required cookieGroup here, that can't be revoked on the cookies page) .

gdpr:

{% if gdprCookieAllowed('matomo') %}
    <h1>Allow Matomo Cookies // add js <h1>
{% endif %}

Refer to

->where('required', true)
where the cookieGroup must be required.

Any advise on this? Is it a misconfiguration or am I just blind to see the problem?

from oc-gdpr-plugin.

tobias-kuendig avatar tobias-kuendig commented on May 23, 2024

Setting a cookie as required means that it will always be enabled, even without a user's consent. This is for things like October's session cookie. These cookies are allowed to be included without consent if they are absolutely required for the page to work correctly.

Your Matomo cookie is not a required cookie. It should only be added if the user accepts it.

Might this be the missunderstanding or do I not understand your question correctly?

from oc-gdpr-plugin.

pixelpanik avatar pixelpanik commented on May 23, 2024

The differences between the cookies required for the page to work correctly and additional cookies is clear to me.

The problem still persists that for those not mandatory cookies the conditional {% if gdprCookieAllowed('matomo') %} somehow returns false and the soft reload is not happening and no cookie code is applied.

Do you mind to check this on our dev site [url removed]?

The plugin is awesome, we only need to get it working :) Thank you very much!

from oc-gdpr-plugin.

tobias-kuendig avatar tobias-kuendig commented on May 23, 2024

It looks like you currently only have one cookie registered:

http://hella-bulbs.trustpb.de/en/cookies

Do you have its initial state set to active?

image

from oc-gdpr-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.