Travis branch name is wrong about oh-my-fish

[jeremiejig]

In our test setup, we don't call bin/install we call tools/travis_install_omf.sh.

As you can see I added a hook when the build is a PR.

About the PR, well I'll have to look into it, as I don't know what really happened

[bpinto]

Inside travis_install_omf.sh we call bin/install:
https://github.com/oh-my-fish/oh-my-fish/blob/master/bin/install#L33-L34

Am I missing something?

[jeremiejig]

Yep I override git in travis_install_omf.sh and treat clone differently.

See here https://github.com/oh-my-fish/oh-my-fish/blob/master/tools/travis_install_omf.sh#L7

You should keep tools/travis_install_omf.sh for docker. It normally work everywhere as on a non-travis environment there isn't any TRAVIS_env variable.

[bpinto]

That only changes the git travis does, not the git bin/install does. See comment above.

Update: OHHHHHH I see it now. Man, that's a HACK in capital letter. 💃

[bpinto]

Closing it as it's only a bug on #80

[derekstavis]

You won a ⭐ for this git override thing haha