GithubHelp home page GithubHelp logo

Comments (4)

ohler55 avatar ohler55 commented on August 17, 2024

I need to look into it. In general the new parser does not have all the options the old one does. That is intentional as the number of detailed options caused confusion and were often the cause of issues where they were not working exactly the way different developers wanted them to.

from oj.

semaperepelitsa avatar semaperepelitsa commented on August 17, 2024

These options are easy enough to implement on client-side. If they are not offered by other implementations, dropping them seems fine. But :empty_string=>false behavior is how it works by default in Ruby's built-in JSON and in Javascript, so it seems wrong not to have it here.

from oj.

ohler55 avatar ohler55 commented on August 17, 2024

I'll look at it tonight. I'm trying to avoid falling into the trap of being just like the JSON gem but I could see the reason it might be reasonable to raise on anything other than a non-empty string.

from oj.

ohler55 avatar ohler55 commented on August 17, 2024

Please try the raise_on_empty branch. A test was added in test/test_parser_usual.rb:150.

from oj.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.