GithubHelp home page GithubHelp logo

Comments (8)

ohler55 avatar ohler55 commented on June 2, 2024 1

I'll add some more tests tomorrow. Just got back tonight from taking pictures of moose and feeding mosquitoes. :-)

from ojg.

raidancampbell avatar raidancampbell commented on June 2, 2024 1

whoops, yes. I'm out of town and unable to give this a more thorough verification, but the diffs looks good to me!

from ojg.

ohler55 avatar ohler55 commented on June 2, 2024

I completely missed that. Branch "marshalers" has an implementation and I will add unit tests over the next day or two.

from ojg.

ohler55 avatar ohler55 commented on June 2, 2024

Unit tests added.

from ojg.

raidancampbell avatar raidancampbell commented on June 2, 2024

hmmm. I can see that the MarshalJSON func is invoked in your test, but I'm not able to replicate it in my above code. It looks like the appendJSON type switch is passing over json.Marshaler and just hitting the default. The incoming data to that function is []TestStruct and the appendDefault code doesn't look to recurse back into the function to check for a json.Marshaler inside the struct.

Thanks for the prompt turnaround though, you've been extremely quick and helpful in the last couple issues!

from ojg.

ohler55 avatar ohler55 commented on June 2, 2024

Pushed another update that adds the missing support to struct members. More unit tests are needed but a modified version of your test is included in the struct_test.go.

from ojg.

ohler55 avatar ohler55 commented on June 2, 2024

OjG v1.11.1 has the fix and has been released. The https://github.com/ohler55/compare-go-json project has also been updated with the latest versions.

from ojg.

ohler55 avatar ohler55 commented on June 2, 2024

Can this be closed?

from ojg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.