Comments (9)
Thanks for the find. I would not have expected that since the documentation makes no mention of the restriction. I'll take a look at what the best work around is.
from ojg.
Please try the "32-bit" branch.
from ojg.
Yes, 32-bit branch seems fine, thanks!
from ojg.
Yep, agree – this is not obvious at all. One important thing I just realized is that math.MaxInt
was only added in Go 1.17, so relying on it will make it impossible to build ojg
on Go < 1.17.
from ojg.
The MaxInt64 is meant to be the limit on and array length for filters. I suspect no one could reasonably complain about a maximum of 21474836487.
from ojg.
The develop branch has what I hope is a fix.
from ojg.
v1.12.6 released with the fix.
from ojg.
@ohler55 thanks!
Just checked it out: 21474836487
is still larger than 2147483647
which is a maximum value for int32, so there are still errors:
❯ GOOS=linux GOARCH=arm go build
# github.com/ohler55/ojg/jp
../../jp/get.go:420:8: constant 21474836487 overflows int
../../jp/get.go:981:8: constant 21474836487 overflows int
../../jp/node.go:262:8: constant 21474836487 overflows int
../../jp/node.go:537:8: constant 21474836487 overflows int
../../jp/parse.go:355:13: constant 21474836487 overflows int
../../jp/parse.go:362:13: constant 21474836487 overflows int
../../jp/slice.go:27:10: constant 21474836487 overflows int
Looks like a typo in a number - maybe using math.MaxInt32
will be better here?
from ojg.
Typo, darn. I'll try again.
from ojg.
Related Issues (20)
- recursive descent on object, unexpected results HOT 7
- Add float write format option HOT 1
- Array type with windowing like functionality? HOT 2
- Panic on setting a nil value on JSONPath HOT 3
- '' is not a valid operation at 16 in $..book[[email protected]] HOT 9
- oj.Unmarshal fails on arrays HOT 4
- Can I get a Normalized Path in JP? (ietf) HOT 13
- Add jp.Expr.Locate() HOT 9
- Support Keyed and Indexed interfaces in `jp.Expr.Modify` HOT 1
- Script with regex fails HOT 3
- Negation operator is not working HOT 11
- The json hierarchy if too deep resulting in no matching HOT 12
- Consider implementing JSONPath HOT 9
- 0x24 ($) is not a valid escaped character HOT 9
- Inconsitent capitalization and loss of capitalization in pretty.JSON for structs HOT 4
- Cannot parse when properties start with "$" HOT 1
- Feature Request: Some way to iterate across object properties (k, v) or at least get keys HOT 7
- Feature Request: enable copy and move of jpath to other parts of hierarchy HOT 2
- Compile failed for the reason that the tag v1.12.8 has been deleted HOT 2
- Cannot delete from array? HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ojg.