`readpartial': end of file reached (EOFError) issue in 1.9 about ox

[ohler55]

Can you send me the file?

[trevorrowe]

I've emailed you the xml file.

[ohler55]

Thanks for the file.

I wrote the following test and got no errors. What are you doing differently? I am also using version 1.5.3 with Ruby 1.9.3-p125. If you can send me a short bit of Ruby code where it breaks I would like to get the problem fixed.

require 'stringio'
require 'ox'

class MySax < ::Ox::Sax
def initialize(); end
def start_element(name); end
def attr(name, value); end
def instruct(target); end
def doctype(value); end
def comment(value); end
def cdata(value); end
def text(value); end
def end_element(name); end
def error(message, line, column)
puts "Error: #{message} at #{line}:#{column}"
end
end

s = File.read('describe_images.xml')
io = StringIO.new(s)
Ox.sax_parse(::Ox::Sax.new, io)
Ox.sax_parse(MySax.new, io)

[trevorrowe]

I had no issues running the example you gave me, yet my benchmark code continued failing. I was finally able to produce a minimal case that demonstrates the error. It has nothing to do with the size of the file xml string (as you can see by the sample below). It appears to be an issue when run from within a rake task. All my other tests are run as Rspec tests, which explains why they worked.

Here are the steps to reproduce.

I ran this with the following versions:

• ruby-1.9.3-p125
• ox-1.5.3
• rake-0.9.2.2
• rubygems-1.8.21

Given the following Gemfile:

source 'http://rubygems.org'

gem 'ox'
gem 'rake'

The following Rakefile:

require 'bundler/setup'

Bundler.require

root = File.dirname(__FILE__)
tasks_dir = File.join(root, "tasks")
$:.unshift(tasks_dir)
$:.unshift(File.join(root, "lib"))

Dir[File.join(tasks_dir, "**", "*.rake")].each do |task_file|
  load task_file
end

And the following task file (tasks/demo_error.rake):

task :demo_error do

  require 'stringio'
  require 'ox'

  class MySax < ::Ox::Sax
    def initialize(); end
    def start_element(name); end
    def attr(name, value); end
    def instruct(target); end
    def doctype(value); end
    def comment(value); end
    def cdata(value); end
    def text(value); end
    def end_element(name); end
    def error(message, line, column)
      puts "Error: #{message} at #{line}:#{column}"
    end
  end

  s = "<xml><foo>bar</foo></xml>"
  Ox.sax_parse(::Ox::Sax.new, StringIO.new(s))
  Ox.sax_parse(MySax.new, StringIO.new(s))

end

And executing it like so:

bundle exec demo_error

Then I get the following stack trace:

/Users/trevrowe/xml-parser/tasks/demo_error.rake:23:in `readpartial': end of file reached (EOFError)
from /Users/trevrowe/xml-parser/tasks/demo_error.rake:23:in `sax_parse'
from /Users/trevrowe/xml-parser/tasks/demo_error.rake:23:in `block in <top (required)>'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/task.rb:205:in `call'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/task.rb:205:in `block in execute'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/task.rb:200:in `each'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/task.rb:200:in `execute'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/task.rb:158:in `block in invoke_with_call_chain'
from /Users/trevrowe/.rvm/rubies/ruby-1.9.3-p125/lib/ruby/1.9.1/monitor.rb:211:in `mon_synchronize'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/task.rb:151:in `invoke_with_call_chain'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/task.rb:144:in `invoke'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/application.rb:116:in `invoke_task'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/application.rb:94:in `block (2 levels) in top_level'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/application.rb:94:in `each'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/application.rb:94:in `block in top_level'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/application.rb:133:in `standard_exception_handling'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/application.rb:88:in `top_level'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/application.rb:66:in `block in run'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/application.rb:133:in `standard_exception_handling'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/lib/rake/application.rb:63:in `run'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/gems/rake-0.9.2.2/bin/rake:33:in `<top (required)>'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/bin/rake:19:in `load'
from /Users/trevrowe/.rvm/gems/ruby-1.9.3-p125/bin/rake:19:in `<main>'

[trevorrowe]

Oops, that should have been:

bundle exec rake demo_error

[ohler55]

Thanks. The bad news is it worked for me on a Mac running the latest OS X, Lion. What platform are you running the test on? I will try to set up a VM to reproduce the problem.

[trevorrowe]

I am running on OS X 10.6.8.

[ohler55]

I have that installed on a machine at home. I will test on that tomorrow after I get back.

[ohler55]

No luck on the machine at home yet. I think I might have to reinstall the OS to get it to build ruby. It's my wife's machine so she will not be happy. I know it is a lot to ask but can I get a restricted login on your machine? If not I understand. There has to be something different that we are missing.

[ohler55]

update, managed to get everything installed and even better I could recreate the problem!

[ohler55]

got it! The behavior of rb_protect() was fixed in the most recent OS. The old one raises an exception even if the code ignores it but Ruby waits until the process completes before raising the exception. Very odd bug in Ruby. I have a work around and will release a fix this week after testing and cleanup.

[trevorrowe]

That explains why I was unable to rescue the exception. Great to hear you were able to reproduce it!

[ohler55]

Please give the latest version a try.

[trevorrowe]

The latest version has resolved the issue for me. Thanks!