Comments (10)
I experienced the same issue with cat > <newfile>
and touch <newfile>
in IntelliJ terminal when propted for the update.
Ok imediatelly after update
from ohmyzsh.
Hi! That's an unfortunate corner case. I think changing the way omz
updates in vscode could be counterproductive for users that don't use the venv
integration. Instead of using vscode
python venv, you could try our python
plugin or disable the whole upgrade system if the terminal where zsh is running is vscode, as follows (before sourcing oh-my-zsh.sh
):
[[ $TERM_PROGRAM == vscode ]] && zstyle ':omz:update' mode disabled
from ohmyzsh.
Could a simple check for incoming input on shell startup suffice? I assume VSCode sends its command right away, faster than a human would, so a simple check for input before prompting user to update could solve the issue for VSCode and any other automated shell-creating programs that could interfere with ohmyzsh and have ohmyzsh interfere with them
from ohmyzsh.
The problem is that the input comes after the shell is initialized, that's why the first char gets cached by the update system.
If the input comes before the question, it already catches it and skips update.
from ohmyzsh.
what if the update prompt simply tells the user to run an update command and doesn't directly ask/listen for a y/n input?
from ohmyzsh.
You can choose that as well by setting the update mode reminder
. You can read about it in the README!
from ohmyzsh.
But given the wide adoption of VSCode as an editor is there a chance we could make the case for having that as a default?
from ohmyzsh.
I think that's an idea in the short run, let's add the check ourselves, but ideally in the long run I'd like to have a better solution for delayed initial input.
from ohmyzsh.
I'm not able to reproduce this in VS Code (tried following [1] to no avail), and I don't have IntelliJ installed to reproduce this. Could you write a bullet point list of the steps to set this up, and confirm that you're in the latest OMZ version?
from ohmyzsh.
Why not just avoid capturing initial terminal output, which anecdotally conflicts with more than one application? I think a prompt that asks the user to run a command to update would work just as well in all instances, no?
Is there a big advantage in capturing input? Forcing the user to decide immediately whether they want to update (seems a bit intrusive)?
I appreciate all your effort here, just an idea of what I would do here 🙏
from ohmyzsh.
Related Issues (20)
- omz_urlencode:45: pcre_exec() error [-10] HOT 1
- No space found between folder name and command in visual studio code HOT 1
- Support alacritty-direct $TERM in title() function
- Alias Arguments Not Being Recognized HOT 2
- Unexpected backslash ( \ ) when opening in vscode terminal HOT 1
- ohmyzsh/aws plugin aws profile not persisting across sessions HOT 1
- `omz plugin disable` breaks .zshrc file when disabling common substring HOT 10
- Minimal theme: prompt does not display information about git status HOT 1
- rsync-move has not delete directory. HOT 2
- fzf_setup_using_fzf:6: command not found: is-at-least HOT 2
- plugins/wd: update to v0.6.1
- plugins/wd: update to v0.6.1
- (eval):10: parse error near `^M' HOT 3
- Call out during install that you must copy from old .zshrc
- Interface Bug HOT 2
- [Plugin] Salt error command not found: python2 when cache autocomplete does not exist
- kubectl plugin completions not working for kj, kjx, ky
- Add FAQ for brew installation
- omz update raises "upgrade.sh:186: bad pattern: ^[[31m"
- plugins/wd: update to v0.7.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ohmyzsh.