Comments (4)
This issue has been superseded by code changes. The trim_quality
parameter is now applied only once, using samtools view
to create a "trimmed" BAM file which is then input to the stats calculations:
bam-qc-metrics/bam_qc_metrics/bam_qc.py
Line 44 in b86d16b
I think this is the behaviour we want, but if I'm mistaken please let me know.
from bam-qc-metrics.
It would make sense to change the name of the parameter. To me, trim_quality
implies that each read is being shortened based on quality. As samtools view
is being used, this does not happen. The samtools
docs has Skip alignments with MAPQ smaller than INT [0].
, so maybe skip_below_mapq
from bam-qc-metrics.
Yes, that makes sense. I'll rename the variable.
from bam-qc-metrics.
Implemented in commit 7f3fd23
from bam-qc-metrics.
Related Issues (11)
- CIGAR of read reverse strand HOT 2
- read_mark_duplicates_metrics HOT 3
- sample_rate parameter is not passed on HOT 2
- Include a genome reference in the repository for tests HOT 1
- Version update script
- Failure if --target not given HOT 1
- Failure with incompatible reference file HOT 1
- Speed up tests HOT 1
- Version update script failure HOT 1
- Remove downsampling and filtering? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bam-qc-metrics.