GithubHelp home page GithubHelp logo

trim_quality usage about bam-qc-metrics HOT 4 CLOSED

slazicoicr avatar slazicoicr commented on July 30, 2024
trim_quality usage

from bam-qc-metrics.

Comments (4)

iainrb avatar iainrb commented on July 30, 2024

This issue has been superseded by code changes. The trim_quality parameter is now applied only once, using samtools view to create a "trimmed" BAM file which is then input to the stats calculations:

if self.trim_quality:

I think this is the behaviour we want, but if I'm mistaken please let me know.

from bam-qc-metrics.

slazicoicr avatar slazicoicr commented on July 30, 2024

It would make sense to change the name of the parameter. To me, trim_quality implies that each read is being shortened based on quality. As samtools view is being used, this does not happen. The samtools docs has Skip alignments with MAPQ smaller than INT [0]., so maybe skip_below_mapq

from bam-qc-metrics.

iainrb avatar iainrb commented on July 30, 2024

Yes, that makes sense. I'll rename the variable.

from bam-qc-metrics.

iainrb avatar iainrb commented on July 30, 2024

Implemented in commit 7f3fd23

from bam-qc-metrics.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.