Comments (4)
I thought we maintained an array of each operation in the squashed form so it should still support multiple Add
.
https://oip.wiki/Squash_Edit
The JS on the wiki seems to show an array being created for each operation
Due to arrays maintaining order, the order of operations would remain within an op type however as mentioned order between types would indeed be lost and lead to potential edge cases resulting in invalid final output such as the index removed/replaced being incorrect if an insert were processed first
Overall, it's probably safest to fall back to full spec RFC6902 if MLG doesn't mind invalidating and rebroadcasting all current oip042 edits.
from oip.
We had initially thought about going down the route of using the arrays for each operation, but decided that for the full ordering between op types, it was worth falling back to the RFC6902 spec.
MLG is ok with invalidating and rebroadcasting all of our current OIP042 edits :)
I am going to work on developing code to perform this work and will create a PR referencing this issue once I have tested it and believe it to be feature complete.
from oip.
Yes, MLG will invalidate the squashed edits. I support making this adjustment.
from oip.
I have opened this PR that will fix this issue once it is merged :)
from oip.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oip.