GithubHelp home page GithubHelp logo

Comments (4)

bitspill avatar bitspill commented on August 21, 2024

I thought we maintained an array of each operation in the squashed form so it should still support multiple Add.

https://oip.wiki/Squash_Edit
The JS on the wiki seems to show an array being created for each operation

Due to arrays maintaining order, the order of operations would remain within an op type however as mentioned order between types would indeed be lost and lead to potential edge cases resulting in invalid final output such as the index removed/replaced being incorrect if an insert were processed first

Overall, it's probably safest to fall back to full spec RFC6902 if MLG doesn't mind invalidating and rebroadcasting all current oip042 edits.

from oip.

OstlerDev avatar OstlerDev commented on August 21, 2024

We had initially thought about going down the route of using the arrays for each operation, but decided that for the full ordering between op types, it was worth falling back to the RFC6902 spec.

MLG is ok with invalidating and rebroadcasting all of our current OIP042 edits :)

I am going to work on developing code to perform this work and will create a PR referencing this issue once I have tested it and believe it to be feature complete.

from oip.

cchrysostom avatar cchrysostom commented on August 21, 2024

Yes, MLG will invalidate the squashed edits. I support making this adjustment.

from oip.

OstlerDev avatar OstlerDev commented on August 21, 2024

I have opened this PR that will fix this issue once it is merged :)

#19

from oip.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.