Package breaks back navigation on Meteor 1.6 if FlowRouter is used about analytics

[derwaldgeist]

Yeah, I can confirm it works after the update. Great work, thanks! 👍

[RichardLitt]

Thanks for logging and researching this issue, @derwaldgeist! Noted.

[cfnelson]

@derwaldgeist v3.0.5 is published 🎉 . I have tested locally with the Flow Router example and all seems good! 😄 Let me know how the latest release goes for you!

Going to mark this issue as resolved, but please open back up if you have any issues. 👍

[cfnelson]

@derwaldgeist Thanks for adding this issue. Could you update the issue title to mention FlowRouter as this bug is specific to FlowRouter. I am also curious to know which versions of this package and flow router you are using. Is their any version changes in these two pkgs when you upgrade to Meteor 1.6.

Also the code related to this is located over in our auto-analytics package. Previously have had other issues relating to flow-router and this integration due to the way it handles history state.

I also suspect that it's not the monkey patch but logPageFirstLoad where we use window.history.replaceSate I am guessing this is why path disappears from the state object.

[cfnelson]

A fix has been created for the above bug and a PR has been opened on our auto-analytics pkg.

We will publish a new meteor analytics package once @okgrow/[email protected] is released.

For further details you can read this comment here.

[derwaldgeist]

Thanks again for the very fast fix! Changed the title so it reflects FlowRouter.

[derwaldgeist]

Shall I close this issue or do you want to keep it open until the update has been published?

[cfnelson]

@derwaldgeist No problems. Lets keep this open until we publish the fix. As I am waiting for a code review on the original PR & will then need to make a new release for meteor analytics once the npm pkg has been published.