[Bug] upgrade_version: unbound variable about sfos-upgrade

[Olf0]

@N-Mi, thank you very much for your excellent and comprehensive bug report. Shame on me, I did not test the "last minute trivial changes" I put into v3.9.13; and even though the changes were trivial, the copy&paste error I repeated six times was trivial too. At least it was also trivial to understand and fix via PR #78.

[N-Mi]

Thanks for your (very) quick fix !

Yes, I tried setting the release using ssu re to check if I could find a workaround, but usually I always used the standard way. That was before I found downgrading to 3.9.12 was working.

Anyway, I also found out I messed something when flashing my phone, so I reflashed it directly using a 4.4.0.64 image (which in fact works, as opposed to what I thought).

I need to upgrade now to 4.4.0.72, I'll use the freshly-released 3.9.14 version :)

[Olf0]

@N-Mi, you wrote:

[…]
# at this point, I had made some tests, including a `ssu re 4.4.0.72` and forgot to reset SSU release to 3.4.0.24, which explains why at first it tries to upgrade to 4.4.0.72
#

[root@Pro1 defaultuser]# sfos-upgrade 
Notice: Upgrading from 3.4.0.24 to 4.4.0.72 would omit installing 4.0.1.48 as a stop release!
Warning: Doing so will likely break this SailfishOS installation, unfortunately often only subtly so the issues caused might be observed way later!
Do you really want to continue? (y/N)  
Aborting upon user request.
[root@Pro1 defaultuser]# sfos-upgrade 4.0.1.48
[…]

If you use sfos-upgrade 4.4.0.72 (repetitively, each time followed by a reboot, the final run followed by a post_sfos-upgrade), it will guide you through all stop releases as promised in the README.

Only setting a release version by ssu re <version> and then executing sfos-upgrade without a parameter allows you to "jump over" stop release and to choose a few other dangerous options.

[Olf0]

Released sfos-upgrade 3.9.14, which only has this fix added compared to v3.9.13.

[Olf0]

Anyway, I also found out I messed something when flashing my phone, so I reflashed it directly using a 4.4.0.64 image (which in fact works, as opposed to what I thought).

That has become Jolla's (especially jovirkku's) mantra in the recent years: Because re-flashing with a current release is so easy, it does not matter that upgrading SailfishOS has become fragile.

I need to upgrade now to 4.4.0.72, I'll use the freshly-released 3.9.14 version :)

Did all go fine?

BTW, another Jolla-mantra: Only upgrade SailfishOS at the command line if Jolla's GUI updater (in the Settings app) fails (or is not available: on community ports of SailfishOS).

[N-Mi]

Did all go fine?

Yes, I used the RPM generated by Github action (as it was not available in "Assets" at the time I did it).

[Olf0]

Did all go fine?

Yes,

Thanks for the feedback.

I used the RPM generated by Github action (as it was not available in "Assets" at the time I did it).

I usually test and upload a self-compiled version (on my SailfishOS phone) at OpenRepos and as a release asset at GitHub. I implemented the GitHub CI workflow primarily to check that it builds flawlessly, nevertheless these builds should work fine (I just do not test them; but the final, self-built 3.9.13 package was not tested at all, as you discovered). At my Sailfish-OBS repository and the SailfishOS:Chum community repository, OBS builds these packages.