Comments (27)
I am sorry for very late reply. Please go ahead and change the license. Sadly, years went without me seeing the message. My old Github handle was @nakeep.
from rust-si.
This is kinda on purpose. If someone worries about whether the term "intent to harm" applies to them, it does.
I don't really have an issue with going to a free license. If someone makes a relicense PR with checkboxes for all past, present and future contributors, I'll merge it without complaint.
from rust-si.
Do you really mean to include future contributors as a criteria for relicensing?
from rust-si.
lol, no, sorry. But the license change should include wording so that any contributions (past and future) are under e.g. Apache2 + MIT licenses.
from rust-si.
Cool. For past contributors, we can try to see if we can contact them to ask if they are willing to switch to a free license. For future contributors, I recommend using the DCO - it's just a way for contributors to certify that their patch is FOSS and more explicitly, that they grant it to the project under the same license as the project.
from rust-si.
Greetings contributors! I propose relicensing this project under an OSI approved license. Could each of you reply with a set of OSI licenses that you would agree with relicensing your past contributions under? If there are some common licenses that you can all agree to, then we can pick that one. @oli-obk suggested Apache 2.0 or MIT above, for example.
CC @oli-obk @nakeep @chrisxue815 @quadfault @Ryman
@oli-obk The early commits in the repo were from Oliver Schneider - is that you? That's the only name I saw that I didn't CC above.
from rust-si.
I don't mind. Any OSI license works for me.
from rust-si.
I'll keep a record here for contributors we have heard from:
- @chrisxue815 - Any OSI license
- @oli-obk
- @nakeep
- @quadfault - Any [OSI license?]
- @Ryman
- Oliver Schneider
from rust-si.
Any is fine with me.
from rust-si.
@oli-obk The early commits in the repo were from Oliver Schneider - is that you?
yes
from rust-si.
Any OSI license works for me
Same!
from rust-si.
Hello @nakeep - are you OK with the proposed license changes?
from rust-si.
I have written @nakeep an e-mail to see if they are OK with switching the license here.
For reference, they have written two commits:
https://github.com/oli-obk/rust-si/commits?author=nakeep
from rust-si.
worst case we'll revert their commits and open an issue with the general idea of compile-time checking the correctness
from rust-si.
I've just contributed to this repository. I am OK with the license change.
from rust-si.
Do we have any updates about this progress?
from rust-si.
we could revert @nakeep's commits, their github accounts seems to be dead.
from rust-si.
I executed such command
$ git shortlog --summary --numbered --email
20 Oliver Schneider <[email protected]>
19 Oliver Schneider <[email protected]>
9 Oliver Schneider <[email protected]>
8 Oliver Scherer <[email protected]>
5 Kevin Butler <[email protected]>
4 Ryo Yamashita <[email protected]>
3 Breno Viana <[email protected]>
2 Carl Scherer <[email protected]>
2 MuhammadAnnaqeeb <[email protected]>
2 Oli Scherer <[email protected]>
2 Oliver Schneider <[email protected]>
1 Chris Xue <[email protected]>
1 Lorenz Gorse <[email protected]>
1 Oliver Schneider <[email protected]>
1 Oliver Schneider <[email protected]>
1 Zhenbo Li <[email protected]>
1 quadfault <[email protected]>
How can we find the two patches committe by nakeep in this list?
from rust-si.
git log --author="MuhammadAnnaqeeb <[email protected]>"
should work
from rust-si.
Thanks @oli-obk
I'm trying to revert these two patches and checking if anything would be broken.
commit fe2b3b6d436bf02127d2ff37857083a3f98acf15
Author: MuhammadAnnaqeeb <[email protected]>
Date: Sat Nov 26 01:16:28 2016 +0200
add failing examples, add a test for panic
also switch line ending to LF in .gitattributes to avoid failed tests
because of line ending changing while cloning repo. Also avoid copying
.lock file by listing it in .gitignore
commit fda477c20108470178266fcfaae2bde4cdb3ca75
Author: MuhammadAnnaqeeb <[email protected]>
Date: Fri Nov 25 06:48:35 2016 +0200
allow compilation time checks
use format_args!() macro to allow compile time checks. Now code like:
```
let a: i32;
let b: &mut u8 = &mut 5;
scan!("{}, {}{", a, *b);
```
will not pass compilation, however code as
```
let a: i32;
let b: &mut u8 = &mut 5;
scan!("{:o}, {:o}", a, *b);
```
will pass compilation and fail at runtime
Besides, have we tried to connect him by email?
from rust-si.
Besides, have we tried to connect him by email?
I haven't
from rust-si.
I'm trying to revert nakeep's first commit by #35
For the other commit fda477c it seems that his change has been overwritten (partially) by otherchanges
$ git blame src/lib.rs | grep -i Muhammad
fda477c2 (MuhammadAnnaqeeb 2016-11-25 06:48:35 +0200 224) ($text:expr, $($arg:expr),*) => {
fda477c2 (MuhammadAnnaqeeb 2016-11-25 06:48:35 +0200 227) format_args!($text, $($arg),*);
fda477c2 (MuhammadAnnaqeeb 2016-11-25 06:48:35 +0200 228) };
from rust-si.
I guess just remove
Line 171 in b0e8ce7
and
Line 209 in b0e8ce7
from rust-si.
Thanks @oli-obk
Are we good to go?
from rust-si.
yes
from rust-si.
Hi @oli-obk , do you plan to change the LICENSE file soon?
Besides, I assume a new release (0.1.9?) is needed, so the metadata on crates.io would be refreshed.
https://crates.io/crates/text_io
from rust-si.
Done!
from rust-si.
Related Issues (20)
- Should take Read or BufRead as input? HOT 2
- Trouble with several scan!
- Support 2018 style macro import
- Flush before read HOT 4
- Issue with read! & serde_json::Result
- `clippy::try_err` is triggered
- read! is blocking in debug build but non blocking in release HOT 1
- Consider adding read_line!
- try_scan action that returns None on error
- Hide implementation details from try_scan! HOT 1
- Scan macro doesn't capture whitespace into strings HOT 1
- Travis CI stops working for this project HOT 2
- BUG | `Read` reimported here - scan macro HOT 1
- text_io 0.1.10 and 0.1.12 fails in older code HOT 3
- Is there a way to avoid breaking when entering a wrong input type? HOT 3
- several whitespaces at a stretch HOT 4
- No documentation HOT 4
- Non-panicking mode HOT 7
- Using scan!() to read multiple values from a string source HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-si.