SVG Sprites doesn't work since the viewBox attribute is missing about vue-svg-inline-plugin

[oliverfindl]

Hello,

plugin should work with both Vue@2 and with Vue@3. It worked on my examples when I last published this plugin. I always test it on all examples before publishing. So if you have some issues, please provide some dummy repo, where this issue would be reproducible.

For your first issue with sprites. It's fetching all SVGs as they appear on screen (with lazy loading you can postpone SVGs under fold). Once SVG has been fetched, it can be cached into local storage, so next request won't fetch them again. As for sprites, I didn't test this behavior, so it could be broken in this scenario. I didn't want to implement blocking fetching process, because it could make UI jump around.

For your second issue with viewBox attribute, I can add some new option for transfer/clone selected attributes if sprite directive is present.

If you have more questions, feel free to ask here.

Thanks.

[madebyfabian]

Hello Oliver, thanks for your quick answer!

This sounds very great so far. Until you implemented this, I would make a PR adding a note for this viewBox behaviour into the README, that users must define this manually for now. If that's okay for you.

[oliverfindl]

Hello,

I've published new version which fixes this issue. Check out new attributes.clone option. Unfortunately, this solution is not ideal and is somewhat taxing on performance, but correct solution is not possible without some major code refactoring.

Tested it successfully on all examples.

I also backported it into vue-svg-inline-loader package.

Thanks.

[madebyfabian]

Thank you very much! Works like a charm, at least in my case.

[oliverfindl]

Glad to hear.