GithubHelp home page GithubHelp logo

Comments (9)

AngieEl avatar AngieEl commented on May 26, 2024 2

Hi @olsh,
thank you for the feedback.
Indeed, there's an issue with our API verifier. We've filed it in our issue tracker - API Verifier doesnt' detect binary incompabitility when abstract property isn't implemented. You can follow it to get the latest updates.

from resharper-structured-logging.

olsh avatar olsh commented on May 26, 2024

Well, it looks like the issue with the Jetbrains validation process.
image

The plugin uses compatible API and Jetbrains stated that if the validation has no issues, then the plugin will work with the new R# versions without any issues. Here is the blog post about the new API verifier.
https://blog.jetbrains.com/dotnet/2023/05/26/the-api-verifier/

So, I'll update the target SDK when I have spare time.
Meanwhile it would be nice to open an issue about the validation process.

from resharper-structured-logging.

jacobvalter avatar jacobvalter commented on May 26, 2024

Voting for this one - seeing no activity on Jetbrains side :/

from resharper-structured-logging.

jacobvalter avatar jacobvalter commented on May 26, 2024

Issue marked as fixed on JetBrains side…

from resharper-structured-logging.

olsh avatar olsh commented on May 26, 2024

I tried to migrate to the new SDK, but there are issues with tests
https://ci.appveyor.com/project/olsh/resharper-structured-logging/builds/48373529

I'm going to fix them soon with JB developers' help.

from resharper-structured-logging.

olsh avatar olsh commented on May 26, 2024

It was fixed in 2023.3.0.315-eap04. The version was uploaded to the plugins repository and is waiting for approval from the JB team.
Meanwhile, you can download binaries here https://ci.appveyor.com/project/olsh/resharper-structured-logging/builds/48384070/artifacts

from resharper-structured-logging.

adaskos avatar adaskos commented on May 26, 2024

Hi. I tried using the above NuGet artifact with R# 2023.3.2 but it won't show in local extensions, as if it's not compatible. Should it work?
Is there a reason why JB hasn't approved it yet?

from resharper-structured-logging.

olsh avatar olsh commented on May 26, 2024

The preview version was approved and it's compatible with Rider 2023.3.2
https://plugins.jetbrains.com/plugin/12832-structured-logging/edit/versions

As for R#. The 2023.2.0.305 should be compatible with R# 2023.3.2
https://plugins.jetbrains.com/plugin/12083-structured-logging/edit/versions

from resharper-structured-logging.

adaskos-signal avatar adaskos-signal commented on May 26, 2024

Thanks @olsh.
I didn't realize that I have to enable Include prerelease packages to get the new version to appear.
It all worked fine after that.

from resharper-structured-logging.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.