Comments (7)
omsmith
commented on July 20, 2024
Is this not fixed by/related to ba05862 and #4?
from ims-lti.
Tape
commented on July 20, 2024
I actually have been debugging and this may be a Canvas specific issue, upon inspection I find my query params listed twice. Turns out those query parameters were added to the request body. I'm doing one last test to verify that is the case but I'm actually finding no issues with this extension itself.
from ims-lti.
Tape
commented on July 20, 2024
Just checked the raw request body and it looks like it's including the query params. I'll speak with a Canvas tech and see if there is something we're overlooking. Doesn't appear to be in the spec though.
from ims-lti.
Tape
commented on July 20, 2024
Going to cross reference the ticket: instructure/canvas-lms#600
from ims-lti.
omsmith
commented on July 20, 2024
Great, will let you run with it
from ims-lti.
Tape
commented on July 20, 2024
Going to go ahead and implement this as a "fix" since their choice of implementation is a little off. I'll go ahead and put in some code to special case incoming Canvas requests.
from ims-lti.
Tape
commented on July 20, 2024
Fixed by #41
from ims-lti.
Related Issues (20)
- Consumer javascript implementation for comment
- What type of request objects are expected? HOT 2
- Doesn't work when launching to https HOT 4
- broken links on README.md
- HTTPS launches always result in an invalid signature. HOT 1
- Sending content urls back to consumer beyound express or from the client
- Is verifying the nonce necessary when the request is done over ssl?
- Any chance of a point release for ContentItemSelectionRequest validation? HOT 4
- Support x-forwarded-host header HOT 1
- Does it work with Canvas authentication? HOT 1
- Error class gotcha
- redis-nonce-store should catch redis errors
- How to specify ext_content in LTI request? HOT 1
- node-uuid deprecation warning
- lodash-node deprecation warning
- Additional Maintainers? HOT 2
- Invalid LTI consumer response may result in empty error HOT 3
- Reading a student grade when she has none yet results in an error.
- LTI 1.0 signing not up to specs for hmac-sha1 HOT 23
- TypeError: Cannot read properties of undefined (reading 'host')
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ims-lti.