Comments (6)
Hi @qzminski, will look into it ASAP. Thanks for reminding!
from handorgel.
Hey @qzminski @iskrisis
Finally I looked into it and the height is set now to auto
after animating or directly to auto
if no transition is desired. So I could remove the resizing listener, methods and no-transition classes, because they are not needed anymore. It's published as 0.5.0 version.
from handorgel.
Works like a charm, thanks a lot!
from handorgel.
Hi @iskrisis
I think you are right, the height should be set to auto, when the animation has finished and stay like this to avoid calculations during resize. I hope that I can fix it next weekend.
from handorgel.
I am sorry i wasn't able to do pull request i am in middle of a job and i just had to bang out nested animated accordion quickly. I ended up doing it by hand using velocity.js. But since i tried like every accordion there is i can safely tell you yours is the best out there right now. I will for sure use it in the future.
I am not sure why but there is big collapsible/accordion drought everything is either unmaitained/legacy that animates slowly using JS or made for react/angular/vue.
If your aim is popular library i think you are on right track! Also the codebase is nice i digged through it when i wanted to make my changes and if i understood it then anyone can! In the end i had some problems with build process so i gave up.
Thank you for your work.
from handorgel.
Hey @oncode, first of all thanks for the great library! Do you have any plans on fixing this issue? @iskrisis solution seems to work but is not perfect βΒ the content collapses immediately without any animation, which should likely not happen.
from handorgel.
Related Issues (18)
- Add option to specify handorgel classes HOT 3
- Can I open an accordion using an external trigger? HOT 2
- Init Handorgel only on mobile HOT 1
- Styling with only animations HOT 1
- handorgel is not a constructor
- Different Markup HOT 2
- --open classes don't always get removed when a handorgel closes HOT 7
- Import SASS from node_modules HOT 1
- seems npm needs to be updated?
- Close animation HOT 2
- [aria-*] attributes do not match their roles HOT 2
- Nested Accordions Issue HOT 4
- Demo HOT 2
- Auto Generate handorgel__header HOT 2
- Uncaught ReferenceError: Handorgel is not defined HOT 4
- Use other element than a button.. HOT 2
- IE10 Support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from handorgel.