GithubHelp home page GithubHelp logo

Nesting - height: auto about handorgel HOT 6 CLOSED

oncode avatar oncode commented on August 19, 2024
Nesting - height: auto

from handorgel.

Comments (6)

oncode avatar oncode commented on August 19, 2024 1

Hi @qzminski, will look into it ASAP. Thanks for reminding!

from handorgel.

oncode avatar oncode commented on August 19, 2024 1

Hey @qzminski @iskrisis
Finally I looked into it and the height is set now to auto after animating or directly to auto if no transition is desired. So I could remove the resizing listener, methods and no-transition classes, because they are not needed anymore. It's published as 0.5.0 version.

from handorgel.

qzminski avatar qzminski commented on August 19, 2024 1

Works like a charm, thanks a lot!

from handorgel.

oncode avatar oncode commented on August 19, 2024

Hi @iskrisis
I think you are right, the height should be set to auto, when the animation has finished and stay like this to avoid calculations during resize. I hope that I can fix it next weekend.

from handorgel.

iskrisis avatar iskrisis commented on August 19, 2024

I am sorry i wasn't able to do pull request i am in middle of a job and i just had to bang out nested animated accordion quickly. I ended up doing it by hand using velocity.js. But since i tried like every accordion there is i can safely tell you yours is the best out there right now. I will for sure use it in the future.
I am not sure why but there is big collapsible/accordion drought everything is either unmaitained/legacy that animates slowly using JS or made for react/angular/vue.

If your aim is popular library i think you are on right track! Also the codebase is nice i digged through it when i wanted to make my changes and if i understood it then anyone can! In the end i had some problems with build process so i gave up.

Thank you for your work.

from handorgel.

qzminski avatar qzminski commented on August 19, 2024

Hey @oncode, first of all thanks for the great library! Do you have any plans on fixing this issue? @iskrisis solution seems to work but is not perfect – the content collapses immediately without any animation, which should likely not happen.

from handorgel.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.