Comments (2)
@siddhesh , thank you for contribution and sorry for a long responce.
We have considered your patch and your idea is worth contributing. However, it looks like your idea can be applied for armv7a as well (as it also has the yield
instruction), so we would prefer to have all arm-related code in one file. In addition, it will be easier to extend for further arm generations. Could you merge the newly added file into gcc_armv7.h
(perhaps renamed to gcc_arm.h
) using gcc_generic.h
for all generations beside armv7a (for which you keep the current one) and implementing __TBB_Pause
with your approach?
I would also recommend to open a pull request on github with your patch to simplify the communication process (we can add comments bound to the code).
from onetbb.
Thanks for your feedback. I'll rework my patch and send it to you shortly. A PR on github actually works much better for me too, I just assumed y'all preferred the traditional route since that's the documented method on the website :)
I'll close this issue and open a PR when I have the patch. Thanks!
from onetbb.
Related Issues (20)
- Facing Deadlock issue with nested TBB HOT 8
- Accessible non-virtual destructor HOT 5
- Will using different versions of the library conflict with each other and cause undefined behavior? HOT 3
- TBB cannot be build from FetchContent if OVERRIDE_FIND_PACKAGE is specified
- Build fails within freedesktop runtime HOT 2
- ASAN with gcc11 (RTLD_DEEPBIND flag which is incompatible with sanitizer runtime) HOT 4
- Setting `__TBB_DEFAULT_PARTITIONER` doesn't set partitioner in `parallel_for` with step HOT 3
- Undefined reference linking error HOT 6
- Is oneTBB signal-safe? HOT 1
- getting compile error on tag 2021.9.0 with gcc 8.5.0 HOT 3
- Deadlock issue in OpenBLAS with TBB HOT 2
- 2021.12.0: missing tag/release? HOT 3
- Global task_schedule_observer leads to error on WASM and static lib x86 HOT 9
- doc/README.md is misleading HOT 2
- Immediately scheduling task on a different thread HOT 9
- std::aligned_storage is deprecated in C++23 HOT 1
- Security.md: replace incorrect email address
- Support priority for join_node HOT 1
- CMake FetchContent fails to install oneTBB HOT 1
- Avoid split constructor for the Range concept HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onetbb.