GithubHelp home page GithubHelp logo

Comments (6)

runningdeveloper avatar runningdeveloper commented on August 18, 2024

Hi here is a github action that might help https://github.com/lycheeverse/lychee-action

from academy.

darigovresearch avatar darigovresearch commented on August 18, 2024

@runningdeveloper thanks for raising this potential solution. @chrismclarke what do you think?

from academy.

chrismclarke avatar chrismclarke commented on August 18, 2024

I really like the idea of using a github action, that way we can set it up as a cron task to check regularly (e.g. if something has been moved) instead of during deployment (which doesn't happen very often).

I've just opened up a PR to test:
#142

You can see the full output from the run here:
https://github.com/ONEARMY/academy/runs/3786194423?check_suite_focus=true

It also created an issue from the report here:
#141

I'm guessing it needs some extra configuration because it's showing a lot of file errors which I don't think are accurate, but maybe someone else can confirm/test a bit more? Feel free to make any updates to the PR if wanting to check/test

I also saw this action: https://github.com/gaurav-nelson/github-action-markdown-link-check
Not sure if there's much difference, happy with whatever works myself

from academy.

chrismclarke avatar chrismclarke commented on August 18, 2024

I just updated the link checker to run after the site is built (to try and fix incorrect asset paths) and the output is better but still seems to report a few false-positives. What do you think @darigovresearch @runningdeveloper ?

Second check output: #143

from academy.

chrismclarke avatar chrismclarke commented on August 18, 2024

Run 3: #145

I tested locally using the tool from command line and actually the output was looking much nicer (only a couple broken links), so I just tried bumping the version to latest (docs were outdated) and this time looking better again. I also reverted the build step as appears to be working from raw markdown which is a bit faster

from academy.

darigovresearch avatar darigovresearch commented on August 18, 2024

@chrismclarke nice work. GitHub actions seems like a good approach. Showing the error page & the link that is not working is really helpful!

from academy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.