Wrong checksum is size >= 2,147,483,647 about xxhash

[OneOfOne]

Can you try with go 1.8 or 1.7 and see if you notice the same behavior? I'll try to look into it.

[newtoncorp]

Same behavior with go 1.8, also same behavior with using a loop instead of io.Copy.

[newtoncorp]

Hello,

Did you have time to look into this ?

[OneOfOne]

Sorry didn't have time.

[newtoncorp]

Hello,

I've think I've found out what happened.
It's with this commit : a625d8a

In XXHash64 struct you've replaced ln uint64 by ln, memIdx int32.
So https://github.com/OneOfOne/xxhash/blob/master/xxhash.go#L103 should be a uint64.

There's also an int32 cast in https://github.com/OneOfOne/xxhash/blob/master/xxhash_go17.go#L238 that might cause issues.

Is this analysis correct ?

[thedrow]

@newtoncorp It looks like you are correct. @OneOfOne will you accept a PR fixing this?

[OneOfOne]

@thedrow PRs are accepted, I've been very busy.

[OneOfOne]

@newtoncorp please test and reopen if that's not the issue, if you can create a minimal test case It'd be great.