Comments (8)
Can you try with go 1.8 or 1.7 and see if you notice the same behavior? I'll try to look into it.
from xxhash.
Same behavior with go 1.8, also same behavior with using a loop instead of io.Copy.
from xxhash.
Hello,
Did you have time to look into this ?
from xxhash.
Sorry didn't have time.
from xxhash.
Hello,
I've think I've found out what happened.
It's with this commit : a625d8a
In XXHash64 struct
you've replaced ln uint64
by ln, memIdx int32
.
So https://github.com/OneOfOne/xxhash/blob/master/xxhash.go#L103 should be a uint64.
There's also an int32 cast in https://github.com/OneOfOne/xxhash/blob/master/xxhash_go17.go#L238 that might cause issues.
Is this analysis correct ?
from xxhash.
@newtoncorp It looks like you are correct. @OneOfOne will you accept a PR fixing this?
from xxhash.
@thedrow PRs are accepted, I've been very busy.
from xxhash.
@newtoncorp please test and reopen if that's not the issue, if you can create a minimal test case It'd be great.
from xxhash.
Related Issues (20)
- Unable to write more than 1G of data using CGO engine HOT 1
- Remove the cgo version. HOT 3
- investigate removing the unsafe version
- Panic occasionally with unsafe version of writeString() HOT 4
- README is not updated to reflect that this is a native implementation now HOT 1
- clean up the code once the go inliner gets a little bit smarter HOT 3
- uint64 too large HOT 3
- new release? HOT 2
- get hash of full object if i have parts HOT 5
- OneOfOne and cespare xxhash implementations give different results HOT 3
- 'type [2147483647]byte larger than address space' when cross compiling HOT 6
- TestSum64 test fails on bigendian HOT 3
- New tag HOT 4
- [PENDING] Windows binary HOT 4
- runtime error: unsafe pointer conversion HOT 2
- Playground doesn't work
- Make New32 and New64 return hash.Hash HOT 5
- Look into checkptr
- Maintenance mode?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xxhash.