NULL user created if you hit 'cancel' on Google login page about barkeep

[philc]

It was you!!

On Tue, Jun 23, 2015 at 2:21 PM, Michael Quinn [email protected]
wrote:

To repro:

1. Clear cookies
2. Navigate to barkeep. You'll be re-directed to Google's login page.
3. Instead of granting access, hit 'cancel'

A NULL user row will appear in the users table. Exceptions will appear in
the log:

172.20.34.61 - - [23/Jun/2015 21:14:18] "GET / HTTP/1.0" 302 - 0.0011
NoMethodError - undefined method downcase' for nil:NilClass: /opt/barkeep/releases/201505081452/models/user.rb:66:ingravatar'
views/layout.erb:65:in block in singletonclass' views/layout.erb:65532:ininstance_eval'
views/layout.erb:65532:in singletonclass' views/layout.erb:65530:in__tilt_15955940'
/home/barkeep/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/tilt-1.3.3/lib/tilt/template.rb:140:in call' /home/barkeep/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/tilt-1.3.3/lib/tilt/template.rb:140:incached_evaluate'
/home/barkeep/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/tilt-1.3.3/lib/tilt/template.rb:127:in evaluate' /home/barkeep/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/tilt-1.3.3/lib/tilt/template.rb:76:inrender'
/home/barkeep/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/sinatra-1.3.2/lib/sinatra/base.rb:636:in render' /home/barkeep/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/sinatra-1.3.2/lib/sinatra/base.rb:644:inblock in render'
/home/barkeep/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/sinatra-1.3.2/lib/sinatra/base.rb:644:in catch' /home/barkeep/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/sinatra-1.3.2/lib/sinatra/base.rb:644:inrender'
/home/barkeep/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/sinatra-1.3.2/lib/sinatra/base.rb:522:in erb' /opt/barkeep/releases/201505081452/barkeep_server.rb:236:inblock in class:BarkeepServer'

—
Reply to this email directly or view it on GitHub
#515.

[zdyn]

126b1b1