stub_const doesn't work quite the same in opal 0.9 about opal-rspec

[wied03]

stub_const has always had lingering issues. I've never been a fan of it in my tests though so it hasn't been a problem for me. Frankly, I can't imagine it becoming much of a priority as long as Opal's underlying constant issue is there.

If I get some time I'll try and see what's going on. Most of my energy right now though has to go towards getting RSpec 3.4 working.

[catmando]

no big deal but do you have any recommendation for fixing that spec? What I am doing now is to just declare TestMod123::Bar outside the spec, and let it sit there... These test structures go back to @zetachang, so perhaps there is a better way?

[wied03]

Any reason they have to be assigned a constant? Why not do it like this?

  it "can add class names by the haml .class notation" do
    mod123 = Class.new(React::Component::Base) do
      collect_other_params_as :attributes
      def render
        "a man walks into a bar".span(attributes)
      end
    end
    foo = Class.new(React::Component::Base) do
      def render
        mod123().the_class
      end
    end

    expect(React.render_to_static_markup(React.create_element(foo))).to eq('<span class="the-class">a man walks into a bar</span>')
  end

[catmando]

Most cases yes, but specifically I need to test that TestMod123::Bar works... so I need at least one test that I do assign to a constant...

[wied03]

Why though? Is this to test the React display name stuff?

[catmando]

No because in the dsl you can do this:

def render
TestMod123::Bar()
end

[wied03]

OK I see. You're testing the equivalent of this: http://ruby-doc.org/core-2.2.3/Kernel.html#method-i-String

[wied03]

I think doing this with any type of anonymous class will be difficult. Even in MRI, included doesn't know the name of the class yet. Getting opal and opal-rspec to do something different could be quite tricky and probably not desirable.

code:

module Foo
  def self.included(base)
    puts "we are #{base}"
  end
end

class Bar
  include Foo
end

Toodles = Class.new do
  include Foo
end

MRI output:

we are Bar
we are #<Class:0x007fc08b886a78>

I think even with vanilla RSpec on MRI, you wouldn't get this to work without hacking/calling included again, etc.

I think creating a normal fixture class outside of the test might be your best option. Might want to make the behavior fail gracefully in case someone wants to use an anonymous class for a React component.

[elia]

missing/broken features are now tracked by spec filters on master