Comments (5)
How about a --kill-others-on-sigint
? I'm not sure I understand the interaction with "restart" here. If the user cancels the process, I'd expect the main process (concurrently) to stop the subprocesses.
Don't the restart flags default to 0
?
from concurrently.
Should restart give the commands a chance to run? No. Not on SIGINT. The user is aborting the process.
Thinking of docker restart policies:
- on-failure
- always
- unless-stopped
None of these restart when the container is manually stopped: even "always" explicitly doesn't include if it's manually stopped.
from concurrently.
Thanks for the report! I think this use case makes sense.
There's a potentially funny interaction with --restart-tries
here. The first command will restart N times before giving up, but should other commands be given a chance to spawn at all?
from concurrently.
Don't the restart flags default to 0?
Yes.
The issue I see starts like this:
concurrently --kill-others-on-fail --max-processes 1 "sleep 5 && echo foo" "exit 1"
- Current behaviour is that command 1 exits, and a SIGTERM (from
--kill-others-on-fail
) is sent to nowhere, so command 0 still runs - New behaviour would be that command 0 shouldn't be given a chance to run, since it was meant to be killed anyways.
But once you add --restart-tries 1
, then it's fair that command 0 gets a chance to run... or not really?
from concurrently.
Yeah, SIGINT has a quite clear use case.
So, --restart-tries
is documented as "restart processes that died". If there's a limited concurrency, then not all commands will be running at once, so they should probably not be given a chance to spawn at all when --kill-others
/--kill-others-on-fail
is set.
I think this makes sense. WDYT?
from concurrently.
Related Issues (20)
- Filter for output of specific commands HOT 4
- Installing package from npm takes a long time HOT 4
- No colors for prefixes when using `prefixColors: "auto"` via concurrent API HOT 3
- How to combine with other node command HOT 1
- CLI options not clear in README HOT 1
- Installing package from npm cnpm yarn takes a long time HOT 2
- Logs of the commands running are not readable HOT 2
- Cancel a series of tasks with SIGINT HOT 5
- Feature Suggestion with wildcards HOT 1
- Error TS2349 using concurrently in full ESM module HOT 1
- Programmatically restarting Command using `kill/start` API produce wrong termination HOT 5
- Allow commands IPC HOT 4
- Feature request: Add or document API option to disable color output
- Prefix ([0] [1]) randomly missing HOT 1
- How to distinguish which process the output stream line comes from HOT 1
- No commands recognized when using via API HOT 1
- concurrently exitcode=0 when it receives SIGINT itself (e.g. on ^C) HOT 2
- Please change the name of the project HOT 1
- Teardown command? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from concurrently.