Comments (4)
leif81
commented on May 26, 2024
Hi @lcowan94
Pull requests are welcome. Would you be interested in submitting a PR for this change?
And could you share a sample pdu to be used here in a junit test to confirm the implementation?
from open-dis-java.
lcowan94
commented on May 26, 2024
Hi, I've got an update with some unit tests for you. How do I submit the pull request?
from open-dis-java.
leif81
commented on May 26, 2024
Terrific.
There's some good info here on creating pull requests.
https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/proposing-changes-to-your-work-with-pull-requests
from open-dis-java.
leif81
commented on May 26, 2024
Thanks again @lcowan94 for the contribution.
I will probably cut a v5.1 release since your change is significant enough. Let me know if that'd be useful for you.
from open-dis-java.
Related Issues (20)
- Dis7 Signal PDU Missing Radio Identifier HOT 8
- Signal PDU data length is in bytes but should be in bits (DIS 7) HOT 2
- DIS Network Traffic on Macs HOT 4
- SISO-REF-010 Updates HOT 4
- Parsing the Articulated Parameters parameter value field HOT 1
- Unmarshal doesn't save/reset buffer position causing issues when with useCopies HOT 2
- Update Maven Central? HOT 2
- DIS time converter HOT 4
- Absence of edu.nps.moves.disenum in Release 5.0 HOT 1
- DIS 7 PDUs advertise zero length HOT 4
- Unmarshaling enters infinite loop if the length field is zero. HOT 2
- A question about CoordinateConversions HOT 8
- Transmitter PDU Variable Parameter Support HOT 2
- Difference with standard protocol for orientation HOT 3
- Deprecate DIS_DR_* and DIS_DeadReckoning classes HOT 1
- BehaviorProducerUDP throws buffer underflow exception when variable datum is greater than MTU HOT 4
- DeadReckoner:perform_DR() for (some) articulated parts not working HOT 1
- Deprecate some disutil classes
- Wrong IFFDataRecord implementation in Java and missing on C++ HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from open-dis-java.