SignalPdu Not Packing Data Correctly about open-dis-python

[japu8876]

Hey @leif81,

I could probably work on a pull request for this and try to catch some of the similar errors in a few of the other pdu types, as well as catch the unit-tests. Probably won't be terribly prompt, but I'll give it a go.

Thanks!

[japu8876]

Looks like this format is repeated often in the file. Some instances appear to track ID objects, which make sense, and others track standard python lists with [], which make less sense, so the whole file might require some grooming for this issue.

[leif81]

Thankyou for the report @japu8876

I realize it's a small change but would you be interested in submitting a pull request for this?

Be aware there's a unit test here that sounds like it needs to be beefed up to catch this issue too if you're interested and able to take that on as part of the pull request?

https://github.com/open-dis/open-dis-python/blob/master/tests/testSignalPdu.py

[yashgharat]

Furthermore, I am also sure that line 7123 should be
read_unsigned_byte()
as that is what the standard calls for. I might be wrong here though.