Wrong unmarshal of Domain in EntityType about opendis7-source-generator

[cruncher64]

Even worse: for values > 5 (e.g. MunitionDomain.ANTI_PERSONNEL), you get a NullPointerException in createPdu in the receiver thread of the DisThreadedNetworkInterface, so one cannot fix the issue in its own code for these cases.

[terry-norbraten]

@cruncher64 I've done some recent work in the DisThreadedNetworkInterface where I was finding too much data was being transmitted/received. Can you test your code above to see if the NPE was fixed?

[terry-norbraten]

@cruncher64 I can certainly reproduce your issue stated above. What is happening is that when you create a new EntityType(), a default PlatformDomain.OTHER is instantiated as a default. We'll have to take a look and see if that's what is intended, or even a best practice, in the source generated code as a default behavior.

[cruncher64]

Yes in the unmarshal method of EntityType you have to do this:

    entityKind = EntityKind.unmarshalEnum(byteBuffer);
    if (entityKind.equals(EntityKind.MUNITION)) {
        domain = Domain.inst(MunitionDomain.OTHER);
    } else if (entityKind.equals(EntityKind.SUPPLY)) {
        domain = Domain.inst(SupplyDomain.NOT_USED);
    }

then it's fine.

[brutzman]

SInce issue remains unresolved, for clarity have renamed this test class as edu.nps.moves.dis7.test.Issue09Unresolved.java