GithubHelp home page GithubHelp logo

Fetch vault owner about od-app HOT 3 CLOSED

pi0neerpat avatar pi0neerpat commented on June 26, 2024
Fetch vault owner

from od-app.

Comments (3)

jahabeebs avatar jahabeebs commented on June 26, 2024

Related to #508

Save the ownerAddress to state

* [ ]  In `fetchSingleVaultData`

* [ ]  When loading safes normally for the user

@pi0neerpat When fetching vaults we only fetch it for the user and only hold those user's vaults in state--when a user views another user's vault then we're just fetching the single safe for that particular user. Are you saying you want to fetch the information for all the vaults in the protocol and hold that in the state?

  • [] In fetchSingleVaultData

This is fetched on demand when a user views someone else's vault--are you saying once they view that particular vault it should be stored in state for as long as possible?

  • [] When loading safes normally for the user

We only fetch the vaults a user already owns (so we know the owner, it's just the user's account). We don't load other vaults until they try viewing another person's vault

from od-app.

jahabeebs avatar jahabeebs commented on June 26, 2024

@pi0neerpat I sent this fix up to Iana's branch here, so I think we can close this. Now we can fetch any vault's owner regardless of if the wallet is connected or not. I added ownerAddress to the ISafe interface that we access via singleSafe

d02b182

Screenshots

Wallet not connected

Screenshot 2024-06-13 at 3 08 17 PM

Wallet connected

Screenshot 2024-06-13 at 3 08 42 PM

from od-app.

pi0neerpat avatar pi0neerpat commented on June 26, 2024

Closed in #515

from od-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.