Comments (3)
Related to #508
Save the ownerAddress to state
* [ ] In `fetchSingleVaultData` * [ ] When loading safes normally for the user
@pi0neerpat When fetching vaults we only fetch it for the user and only hold those user's vaults in state--when a user views another user's vault then we're just fetching the single safe for that particular user. Are you saying you want to fetch the information for all the vaults in the protocol and hold that in the state?
- [] In fetchSingleVaultData
This is fetched on demand when a user views someone else's vault--are you saying once they view that particular vault it should be stored in state for as long as possible?
- [] When loading safes normally for the user
We only fetch the vaults a user already owns (so we know the owner, it's just the user's account). We don't load other vaults until they try viewing another person's vault
from od-app.
@pi0neerpat I sent this fix up to Iana's branch here, so I think we can close this. Now we can fetch any vault's owner regardless of if the wallet is connected or not. I added ownerAddress to the ISafe interface that we access via singleSafe
Screenshots
Wallet not connected
![Screenshot 2024-06-13 at 3 08 17 PM](https://private-user-images.githubusercontent.com/47253537/339539449-345bae4f-86cd-4864-b3a4-213105a189af.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzOTQyMzIsIm5iZiI6MTcxOTM5MzkzMiwicGF0aCI6Ii80NzI1MzUzNy8zMzk1Mzk0NDktMzQ1YmFlNGYtODZjZC00ODY0LWIzYTQtMjEzMTA1YTE4OWFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDA5MjUzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZlY2U3YWJiYTNkZDgwYTYzY2RmNzNiOGRjNjhhN2IwNzI1ZGNhMzY5NzFiYTdjZDlkZGUyMWNhOGFiNGU2YmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rz84fQ--jNnR8VJLSCQ-5Ua7M62c2ugiKjyG9G6o-ZM)
Wallet connected
![Screenshot 2024-06-13 at 3 08 42 PM](https://private-user-images.githubusercontent.com/47253537/339539455-f806785a-5a26-4589-9c4d-0b6903b98792.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzOTQyMzIsIm5iZiI6MTcxOTM5MzkzMiwicGF0aCI6Ii80NzI1MzUzNy8zMzk1Mzk0NTUtZjgwNjc4NWEtNWEyNi00NTg5LTljNGQtMGI2OTAzYjk4NzkyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDA5MjUzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg4NTAyYjNlMjllNGRmNmI4NmUzMmUzNGU1N2FkNDIwZjYyN2RkYWRlOWU3N2I2NDgxY2Y1Y2RjY2E3NzZlODUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bzKn0xruGhqQ5iatirBm4b0lsv0_3tuJyK5zDfDFkNk)
from od-app.
Closed in #515
from od-app.
Related Issues (20)
- QA: Mobile side menu
- Bolts page final cleanup HOT 1
- QA: Tracking error, empty vault
- View / Claim internal balances
- Bridge: Verify token addresses HOT 2
- Proper bolts amount not reflected in app
- Max button rounding to integers when creating vaults HOT 1
- Bolts: Display per-quest points HOT 1
- Vault creation- small deposit warning
- Remove unused images
- Per-quest points HOT 1
- QA release: Bolts
- New wallet component
- Stats page - total system surplus
- Staging Cleanup 06/20
- QA: Header
- QA: create vault
- Matomo analytics
- Matomo e-commerce integration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from od-app.