GithubHelp home page GithubHelp logo

Comments (2)

jahabeebs avatar jahabeebs commented on September 25, 2024

How can we remove all these console logs from the sdk?

Duplicate definition of ModifyParameters (ModifyParameters(bytes32,uint256), ModifyParameters(bytes32,bytes32,uint256))
Duplicate definition of ModifyParameters (ModifyParameters(bytes32,uint256), ModifyParameters(bytes32,address))
Duplicate definition of ModifyParameters (ModifyParameters(bytes32,bytes32,uint256), ModifyParameters(bytes32,uint256), ModifyParameters(bytes32,address), ModifyParameters(bytes32,uint256,uint256), ModifyParameters(bytes32,uint256,uint256,address))
Duplicate definition of ModifyParameters (ModifyParameters(bytes32,uint256), ModifyParameters(bytes32,address), ModifyParameters(bytes32,bytes32,uint256), ModifyParameters(bytes32,bytes32,address))

@pi0neerpat

This specific log can't be turned off in ethers 5 so we have a couple of options:

  1. only allow ethers logging in dev and not in prod (I think this might be best since we still need ethers logging for debugging in dev)
  2. turn off ethers logging for dev and prod
  3. migrate ethers to v6 (would require refactoring of how we use BigNumbers and providers in the SDK--see here: https://docs.ethers.org/v6/migrating/)

related issues:
ethers-io/ethers.js#1029
Midas-Protocol/monorepo#1126

from od-sdk.

pi0neerpat avatar pi0neerpat commented on September 25, 2024

Closing for now. Not high enough priority to continue

from od-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.