Comments (4)
Looks like there might be a bug when generating https://github.com/open-i18n/rust-unic/blob/master/unic/emoji/char/tables/emoji.rsv#L6 so that U+0030..U+0039 were mistakenly extracted out from the original UCD file (https://github.com/open-i18n/data-unicode-ucd/blob/master/data/EmojiSources.txt).
I believe U+0030..U+0039 are only considered as emojis when they are followed by U+20E3.
from rust-unic.
I believe the cause is that https://github.com/open-i18n/rust-unic/blob/master/gen/src/source/emoji/emoji_data.rs#L54 reuses the regex for parsing other binary properties (source::ucd::BINARY_PROPERTIES_REGEX
) however the UCD file for emoji sources has a slightly different format (or rather the code points are represented as a sequence instead of a range).
from rust-unic.
This might also be the reason #
is considered an emoji, which caused a parsing regression when trying to recover identifiers with emoji in rustc
. We're side-stepping the issue by ensuring ASCII chars are never considered emoji in our end.
from rust-unic.
I'm not aware of the specifics of the unicode standard, but I believe that '0' is not an emoji.
Unfortunately, they (along with #
, *
, among others) have the Emoji unicode property, so this is somewhat incorrect. I don't think this is a bug so much as a non-intuitive API.
from rust-unic.
Related Issues (20)
- Upgrade to Unicode 11.0 HOT 1
- Upgrade to Unicode 12.0 HOT 4
- Implement TimeZone HOT 1
- Implement date and time formatting HOT 1
- Implement MessageFormat HOT 2
- Add a `WordIndices` struct HOT 2
- Why fork unicode-bidi? HOT 6
- Proposal: unic-langid and unic-locale HOT 3
- Include LICENSE files into all sub-crates
- WB3d: Keep horizontal whitespace together. HOT 1
- Support sentence boundaries in annex 29
- Update links in unic/README.md
- [unic-bidi] Bugs in visual_runs HOT 1
- [unic-bidi] API concerns HOT 6
- ICU4X HOT 3
- Forked library; and some thoughts about whether it's worth it to keep all modules at same Unicode version HOT 3
- unic-ucd-hangul crate does not contain any license files
- `is_emoji_modifier` documentation is wrong
- 🥰 isn't recognised as an emoji.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-unic.