Comments (1)
I think save in class Prefs used the wrong lock type 'fcntl.LOCK_UN'.
Please see pull #43 for details.
Then, call open via 'wb' will truncate the file without lock protection,
if load prefs.bin at the same time, maybe read empty prefs.bin and
cause EOFError with very low probability.
def save(self, filename=None):
'''
Saves the preferences to disk. If filename is not specified,
use the default one if it is set, else do nothing.
@param filename: Optional alternate file to use.
@type filename: str
'''
if filename is None:
filename = self.filename
if filename is not None:
fsock = open(filename, 'wb')
fcntl.lockf(fsock, fcntl.LOCK_UN)
try:
six.moves.cPickle.dump(self._prefs, fsock, 2)
finally:
fsock.close()
def load(self, filename=None):
'''
Loads the preferences from file. Use either the supplied filename,
or the default one if set. Else, do nothing.
'''
if filename is None:
filename = self.filename
if filename is not None and os.path.exists(filename):
fsock = open(filename, 'rb')
fcntl.lockf(fsock, fcntl.LOCK_SH)
try:
self._prefs = six.moves.cPickle.load(fsock)
finally:
fsock.close()
from configshell-fb.
Related Issues (20)
- Possible RFE: allow spaces in pathnames? HOT 2
- Python 3 only: command line completion is broken when there are several matches HOT 2
- Cannot autocomplete ipv6 portals HOT 1
- make rpm is failing for configshell-fb in RHEL 7.1 HOT 4
- RFC: Add new loglevel between info & debug and tweak ConfigShell.run_cmdline() to log "Running command line" messages to that new loglevel HOT 2
- RFC: Change ConfigShell.run_stdin() to strip whitespace from cmdline? HOT 2
- Accessing IPv6 addresses in targetcli is broken
- configshell-fb raises KeyError: 'TERM' HOT 1
- PyPI package is outdated HOT 9
- 1.1.25 not on PyPI HOT 3
- Proposal to add quoted parameters for command line arguments
- 1.1.26 not on PyPI HOT 2
- Forgot to tag version 1.1.27? HOT 3
- configshell_fb not found HOT 1
- 'NoneType' object has no attribute 'Console' HOT 2
- Indentation issue. HOT 1
- Minimal version required for configshell-fb, target-fb and rtslib-fb? HOT 2
- Release new tag with python3.11 support HOT 1
- Release new tag with python3.11 support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from configshell-fb.