GithubHelp home page GithubHelp logo

Comments (12)

samihamine avatar samihamine commented on September 16, 2024 7

@TheMadKow while waiting for the update, you can modify the index.js file by replacing :

nodes.forEach(node => {
// const getDeps = [...snapshot.getDeps_UNSTABLE(node)];
const getDeps = [...snapshot.getInfo_UNSTABLE(node).deps];
nodeDeps[node.key] = getDeps.map(dep => dep.key);
});

Thanks, @kevintap-idemia for the help ;)

from recoilize.

krupeshanadkat-byjus avatar krupeshanadkat-byjus commented on September 16, 2024 6

This is still an issue

from recoilize.

ibarapascal avatar ibarapascal commented on September 16, 2024 3

Is this issue fixed? because I also tried to add this change in the index.js file and the chrome extension just crashed!

I believe the PR which fixed this issue was merged (#140), and it would be included inside the release of v3.0.0 if it comes in the near future as planned.

from recoilize.

johannbuscail avatar johannbuscail commented on September 16, 2024 2

@Sammyham Thanks for the solution!
Could you create a pull request for that please ?

from recoilize.

kevintap-idemia avatar kevintap-idemia commented on September 16, 2024 1

I suspect that this is not being merged due to backwards compat concerns. The PR would allow compatibility with recoil 0.2.0+, but would then break compatibility with older recoil releases (0.1.3), which is the current stated compatible/tested recoil release in the docs for the recoilize 2.0.1 release. Perhaps @Sammyham if you re-work your PR to allow backwards compat, this might be simpler to merge?

from recoilize.

showmen-gupta avatar showmen-gupta commented on September 16, 2024 1

Is this issue fixed? because I also tried to add this change in the index.js file and the chrome extension just crashed!

from recoilize.

adamdaly avatar adamdaly commented on September 16, 2024 1

I'm getting another error after I updated the getDeps function:

Uncaught TypeError: Cannot read properties of undefined (reading '_internalRoot')

with the function:

const createDevToolDataObject = (filteredSnapshot, diff) => {
    if (diff === undefined) {
      return {
        filteredSnapshot: filteredSnapshot,
        componentAtomTree: formatFiberNodes(
          recoilizeRoot._reactRootContainer._internalRoot.current,
        ),
      };
    } else {
      return {
        filteredSnapshot: filteredSnapshot,
        componentAtomTree: formatFiberNodes(
          recoilizeRoot._reactRootContainer._internalRoot.current,
        ),
        indexDiff: diff,
      };
    }
  };

Is this because I'm using React 18?

from recoilize.

TheMadKow avatar TheMadKow commented on September 16, 2024

Any workarounds for this issue ? :)

from recoilize.

samihamine avatar samihamine commented on September 16, 2024

Same problem, any help please? ๐Ÿ‘

from recoilize.

samihamine avatar samihamine commented on September 16, 2024

Done #140

from recoilize.

stheobald avatar stheobald commented on September 16, 2024

It would be great to get this PR merged - we're having to manually update the index.js everytime we add recoilize, and it's getting a bit tiresome.

The work is already done, just needs merging.
@razananisathar @nbargers is there anything further we can help with to push this along?

from recoilize.

JacopoLuri avatar JacopoLuri commented on September 16, 2024

Thank you for the workaround!

from recoilize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.