GithubHelp home page GithubHelp logo

Comments (22)

Expertium avatar Expertium commented on July 23, 2024 1

image

Alright, so this does change something. Deck-specific parameters still don't work though, even now. OR maybe it just so happened that both global and deck-specific parameters produced the same result. Frankly, I don't know how sensitive intervals are to changes in parameters. Ok, after a bit of testing with different parameters, I think we were fighting a non-existent problem - I think both global parameters and deck-specific parameters just happened to produce (roughly) the same intervals for that card of mine. That also means that it's probably unnecessary to optimize each deck individually, global parameters are probably good enough, aside from some crazy hard or crazy easy decks. We need some kind of sensitivity analysis, like "If I change this parameter by 5%, how much will the interval change?", that sort of thing.
I'll try to enable add-ons back one-by-one.

Aaaaaaaaaaaand the culprit is...Incremental Reading v4.11.3 (unofficial clone).
Ok, so we weren't fighting a non-issue, both this AND the fact that changing parameters seems to only slightly affect intervals were simultaneously causing confusion. God damn incremental reading man, I personally reported like 3-5 bugs for that add-on, what a pain.

Add-ons that don't cause problems:
Advanced Browser
Anki forvo-dl - Forvo Pronunciation Downloader fully automatic
AnkiConnect
AnkiWebView Inspector
CrowdAnki JSON export&import Edit history Collaborate on deck creation.
Enhanced Cloze for Anki 41
export cards/notes from browser with metadata to csv or xlsx
Export in CSV format
Extended Card Stats During Review
Image Occlusion Enhanced
Image Style Editor
Progress Graphs and Stats for Learned and Matured Cards
Quantified Self add-on - export your review log (fork for Anki 2.1)
Remove Duplicate Cards
Review Heatmap
True Retention
The KING of Button Add-ons

Well, at least now you can add these to the list of addons that are compatible with FSRS (or, rather, to the "These seem to work at first glance and don't immediately make the new algorithm shit itself" list). And yes, The King of Buttonf Add-ons doesn't interfere with FSRS, it seems.

from fsrs4anki.

L-M-Sherlock avatar L-M-Sherlock commented on July 23, 2024

Can you open the inspector and run the code to this line? It will show the deck name that the code actually fetchs.

image

from fsrs4anki.

Expertium avatar Expertium commented on July 23, 2024

Yep, it uses the correct deck name, but not the correct parameters.
1

from fsrs4anki.

L-M-Sherlock avatar L-M-Sherlock commented on July 23, 2024

Was var f_s = [0.7249,0.8026] skipped?

from fsrs4anki.

Expertium avatar Expertium commented on July 23, 2024

My global parameters are

var f_s = [0.4112,1.5968];
var f_d = [1.0199,-0.4685,-1.7075,0.0714];
var s_w = [3.5014,-1.3554,-0.138,1.7324,2.9985,-0.0531,0.9896,1.3442];

My parameters for that deck are:

var f_s = [0.7249,0.8026];
var f_d = [1.0007,-0.6561,-1.2081,0.0112];
var s_w = [3.2511,-0.8703,-0.0277,1.5211,2.1651,-0.2846,0.5221,1.2443]

"Scope" shows the wrong parameters, but the right deck name.
1

I'm using scheduler v2.0.3

from fsrs4anki.

L-M-Sherlock avatar L-M-Sherlock commented on July 23, 2024

Can you step over the line 31-38, then to check the scope?

from fsrs4anki.

Expertium avatar Expertium commented on July 23, 2024

image

from fsrs4anki.

L-M-Sherlock avatar L-M-Sherlock commented on July 23, 2024

image

So the parameters have been set. Any other problem?

from fsrs4anki.

Expertium avatar Expertium commented on July 23, 2024

Huh, weird. I'll test it a bit more later, now that I've disabled button king add-on.

from fsrs4anki.

Expertium avatar Expertium commented on July 23, 2024

Well, at this point I'm just confused. I tried enabling and disabling "the king of button add-ons", tried removing the code entirely, and no matter what I do the intervals don't change. Take a look at screenshots - the intervals are the same no matter what. I made sure that V3 scheduler is enabled, restarted Anki every time, etc. I tried using new code (v2.1.0) instead of 2.0.3, nope, still doesn't work.
image

from fsrs4anki.

L-M-Sherlock avatar L-M-Sherlock commented on July 23, 2024

Can you follow these actions in this GIF?

debug

I need easy_interval, good_interval and hard_interval in your case.

from fsrs4anki.

Expertium avatar Expertium commented on July 23, 2024

Here
image
I once again tried enabling and disabling "the king of button add-ons", it doesn't make a difference.

from fsrs4anki.

L-M-Sherlock avatar L-M-Sherlock commented on July 23, 2024

I add a new example of setting parameters for a specific deck:

image

from fsrs4anki.

Expertium avatar Expertium commented on July 23, 2024

image
image
Nope, intervals still don't change, no matter what parameters I use and no matter whether I even use code from fsrs4anki_scheduler.js.
This stuff did change though, but not the intervals that are displayed
image

from fsrs4anki.

L-M-Sherlock avatar L-M-Sherlock commented on July 23, 2024

Do you click show answer before the code run to the end?

from fsrs4anki.

L-M-Sherlock avatar L-M-Sherlock commented on July 23, 2024

You can click the blue arrow to run to the end of the code. Then you click the show answer, and the interval may be different.
image

from fsrs4anki.

Expertium avatar Expertium commented on July 23, 2024

Nope, still the same.

from fsrs4anki.

L-M-Sherlock avatar L-M-Sherlock commented on July 23, 2024

So weird😭.

from fsrs4anki.

Expertium avatar Expertium commented on July 23, 2024

Do you not have the same issue?
I have one last idea in mind - I'll try disabling every single add-on, and see if that helps.

from fsrs4anki.

Expertium avatar Expertium commented on July 23, 2024

image
Ok, I'm getting somewhere. I will turn add-ons on one-by-one, and see if maybe one of them breaks the whole thing (seems like that's what's happening)

from fsrs4anki.

L-M-Sherlock avatar L-M-Sherlock commented on July 23, 2024

I'm looking forward to your good news!

from fsrs4anki.

L-M-Sherlock avatar L-M-Sherlock commented on July 23, 2024

I add the incompatible add-ons to the list at Compatibility.

from fsrs4anki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.