GithubHelp home page GithubHelp logo

Comments (3)

rashmichandrashekar avatar rashmichandrashekar commented on June 19, 2024 2

@swiatekm-sumo - I was thinking having them identical gives us the benefit of keeping the behavior consistent between the 2 target allocator components. But, if we want to avoid the additional coupling I could just add the same method there too.

@jaronoff97 - Sounds good. Yes, the cyclic dependency will be a concern. Looks like the cons outweigh the pro here. I can just add the same method in the receiver too.

from opentelemetry-operator.

swiatekm-sumo avatar swiatekm-sumo commented on June 19, 2024

Do we need these methods to be identical? Exporting the method and depending on the target allocator package in Prometheus receiver is a lot of additional coupling, and I'd rather not do it if it's not absolutely necessary. Can't the receiver just implement the hashing its own way?

from opentelemetry-operator.

jaronoff97 avatar jaronoff97 commented on June 19, 2024

I agree with @swiatekm-sumo, I don't think we should expose this publicly as it will create a cyclic dependency between ourselves and the collector which we should avoid.

from opentelemetry-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.