Comments (3)
@swiatekm-sumo - I was thinking having them identical gives us the benefit of keeping the behavior consistent between the 2 target allocator components. But, if we want to avoid the additional coupling I could just add the same method there too.
@jaronoff97 - Sounds good. Yes, the cyclic dependency will be a concern. Looks like the cons outweigh the pro here. I can just add the same method in the receiver too.
from opentelemetry-operator.
Do we need these methods to be identical? Exporting the method and depending on the target allocator package in Prometheus receiver is a lot of additional coupling, and I'd rather not do it if it's not absolutely necessary. Can't the receiver just implement the hashing its own way?
from opentelemetry-operator.
I agree with @swiatekm-sumo, I don't think we should expose this publicly as it will create a cyclic dependency between ourselves and the collector which we should avoid.
from opentelemetry-operator.
Related Issues (20)
- Use the new k8s distro HOT 12
- Release the operator v0.98.0
- Allow ServiceMonitor/PodMonitor to set custom MatchLabels HOT 2
- Create Namespaces Role/Role Bindings when WATCH_NAMESPACE is set. HOT 1
- Nginx / Apache autoinstrumentation removes too many volumes
- Docs for enabling multi-instrumentation still point to enabling it via the --feature-gates flag HOT 3
- Target allocator allocation stragy mismatch metween v1alpha1 and v1beta1 HOT 1
- Collectors with same name create ClusterRoleBinding with same name HOT 1
- Introduce intermediary structures for config handling
- Helm template to deploy otel collector HOT 10
- Ambiguous target allocator deployment mode compatibility HOT 2
- Target allocator example from readme fails HOT 2
- .Net auto instrument produces no traces HOT 2
- Specify the collector configuration in an external ConfigMap HOT 2
- Metric Collector crashbackoffloop Due to Inability to Reach Target Allocator HOT 1
- Missing notation for Services broke integration with ServiceMonitor HOT 1
- Opentlemetry Operator support for kubernetes 1.30 HOT 3
- OpenTelemetryCollector should have specific serviceAnnotations, podAnnotations, serviceLabels and podLabels settings
- Dose Nestjs support auto instrumentation with Opentelementry HOT 2
- Reconfiguration of OpenTelemetryCollector CR mode is not working like expected HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-operator.