Sampler gives NaN values about skillful_nowcasting

[sjjlr]

I don't understand why the authors transform the radar echo dBZ to rain rate using Z-R relationship? Why don't they directly use radar echo reflectivity?

[xinzhuang]

Thanks for your implementation of dgmr! It's organization is clear,and easy to read.

When I run the test_model.py,I also found the nan values in sampler's output. I check the ConvGRU.py, found that the bug may be aroused by spectral_norm function.

According to PyTorch spectral_norm doc , I use torch.nn.utils.parametrizations.spectral_norm() instead, also spectral_norm in common.py, and it works fine now. I Think you should have a try.

Though I don't know why, hopefully it helps. Thanks.

[jacobbieker]

Oh, thanks for figuring that out! I'll update it to use that now then too

[jacobbieker]

It worked! Thanks so much