GithubHelp home page GithubHelp logo

Opt Out about opencollective-cli HOT 10 CLOSED

opencollective avatar opencollective commented on July 22, 2024 8
Opt Out

from opencollective-cli.

Comments (10)

ckknight avatar ckknight commented on July 22, 2024 4

The extra dependencies this adds (which are incompatible with other dependency versions) leaves an extremely bad taste in my mouth about this project.

from opencollective-cli.

eddiemonge avatar eddiemonge commented on July 22, 2024 2

At least obey npm's loglevel

if (["silent", "error", "warn"].indexOf(process.env.npm_config_loglevel) < 0) {
  showPostInstall();
}

from opencollective-cli.

mlucool avatar mlucool commented on July 22, 2024 1

This is a big step forward, especially since it no longer needs to connect home for stats. Still, I don't see how this fixes the ability to opt out or the fact this shown is once per thing that wants to advertise per install (instead of maybe one message that shows every link only at a given frequency).

from opencollective-cli.

xdamman avatar xdamman commented on July 22, 2024 1

Given that's it's just two lines in the log, is that really such a big issue?
It would be much more complicated to record whether the user has already seen it (and I'd argue not worth it as it adds quite some complexity that could break on different environments as we've learned).

One improvement I could see is to not show it in CI environment. Want to take a stab at it?

from opencollective-cli.

Omeryl avatar Omeryl commented on July 22, 2024 1

@xdamman This isn't two lines?

> opencollective postinstall

                                     .,:;;:,.
                                 ..:;;;rrrrr;;:,.
                             ..:;;rrrrrrrrrrrrrr;;:,.
                         .,:;;rrrrrrrrrsiisrrrrrrrrr;;:,.
                         :issrrrrrrsiiSSSSSSiisrrrrrrssi;
                         ;SiiiiiiSSSSSSSSSSSSSSSSiiiSiiS;
                         ;SS5222222255SSSSSS55222222255S;
                         ;222222222222225522222222222222r
                         ;222222222222222222222222222222r
                         ;222222222222222222222222222222r
                         ;222222222222222222222222222222r
                         ;S22222222222222222222222222225r
                         ,rrsi5222222222222222222225isrr:
                         ,;;;;rrsi52222222222225Ssrr;;;;:
                         ,;;;;;;;;rrsi522225Ssrr;;;;;;;;:
                         .::;;;;;;;;;;rrssrr;;;;;;;;;;::,
                          ..,,::;;;;;;;;;;;;;;;;;;::,,..
                              ..,,::;;;;;;;;;;::,,..
                                  ..,,::;;::,,..
                                      ..,,,.


                          Thanks for installing level 🙏
                 Please consider donating to our open collective
                        to help us maintain this package.

                            Number of contributors: 40
                               Number of backers: 5
                              Annual budget: US$ 216
                             Current balance: US$ 200

           👉  Donate: https://opencollective.com/level/donate

from opencollective-cli.

mlucool avatar mlucool commented on July 22, 2024

Linking the same idea in a different package: opencollective/opencollective-postinstall#8

from opencollective-cli.

ckknight avatar ckknight commented on July 22, 2024

I have made a project that ostensibly allows one to "opt out": https://github.com/ckknight/opencollective-cli

from opencollective-cli.

xdamman avatar xdamman commented on July 22, 2024

Thank you all for chiming here and offering solutions. Sorry about the trouble this has caused. So many edge cases.

We just published a very lightweight version that doesn't have any dependency: https://github.com/opencollective/opencollective-postinstall

Just replace in your package.json the opencollective dependency with opencollective-postinstall and in scripts.postinstall section, replace opencollective postinstall with opencollective-postinstall

Let us know your thoughts and pull requests welcome!

from opencollective-cli.

mlucool avatar mlucool commented on July 22, 2024

@xdamman What do you think about opencollective/opencollective-postinstall#9?

from opencollective-cli.

znarf avatar znarf commented on July 22, 2024

We recommend everyone to use thew new lightweight postinstall:
https://github.com/opencollective/opencollective-postinstall

It does feature "Opt Out" when CI or DISABLE_OPENCOLLECTIVE is set.

from opencollective-cli.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.