new test failures after recent change about libdap4

[sharkcz]

And indeed, ppc64 has the same failures.

[kyang2014]

Dan,

Do these tests fail with the latest libdap4 b177716?

[sharkcz]

yes, those failures are present in latest master branch

[kyang2014]

What's your platform ? Could you also provide the details of the failures?
If we cannot duplicate, it will be hard to fix.

[sharkcz]

As I mentioned earlier I am seeing these failures on s390x and ppc64, both are big endian platforms. Which makes me assume the change from commit 5b419ac isn't endian-safe as everything was passing before that.

details from DMRTest.log

## ------------------------ ##
## Summary of the failures. ##
## ------------------------ ##
Failed tests:
libdap 3.21.0 test suite: dmr-test test groups:
 
 NUM: FILE-NAME:LINE     TEST-GROUP-NAME
      KEYWORDS
 
 139: DMRTest.at:465     trans ce test_simple_8.xml outer test_simple_8.xml.1.trans_base
      trans_ce
 140: DMRTest.at:466     trans ce test_simple_8.xml outer.s.s test_simple_8.xml.2.trans_base
      trans_ce
 141: DMRTest.at:467     trans ce test_simple_8.xml outer{s{s}} test_simple_8.xml.2.trans_base
      trans_ce
 
## ---------------------- ##
## Detailed failed tests. ##
## ---------------------- ##
 
#                             -*- compilation -*-
139. DMRTest.at:465: testing trans ce test_simple_8.xml outer test_simple_8.xml.1.trans_base ...
./DMRTest.at:465: $abs_builddir/dmr-test -x -t $input -c "outer" || true
stderr:
stdout:
Parse successful
<?xml version="1.0" encoding="ISO-8859-1"?>
<Dataset xmlns="http://xml.opendap.org/ns/DAP/4.0#" xml:base="file:dap4/test_simple_8.xml" dapVersion="4.0" dmrVersion="1.0" name="test_simple_8">
    <Structure name="outer">
        <Sequence name="s">
            <Int32 name="i1"/>
            <String name="s"/>
        </Sequence>
    </Structure>
</Dataset>
 
<?xml version="1.0" encoding="ISO-8859-1"?>
<Dataset xmlns="http://xml.opendap.org/ns/DAP/4.0#" xml:base="file:dap4/test_simple_8.xml" dapVersion="4.0" dmrVersion="1.0" name="test_simple_8">
    <Structure name="outer">
        <Sequence name="s">
            <Int32 name="i1"/>
            <String name="s"/>
        </Sequence>
        <Attribute name="DAP4_Checksum_CRC32" type="String">
            <Value>c6f12441</Value>
        </Attribute>
    </Structure>
</Dataset>
 
The data:
{ { { { 123456789, "Silly test string: 1" }, { 123456789, "Silly test string: 1" }, { 123456789, "Silly test string: 1" }, { 123456789, "Silly test string: 1" } } } }
./DMRTest.at:465: diff -b -B $baseline stdout || diff -b -B $baseline stderr
stdout:
20c20
<             <Value>66950c7d</Value>
---
>             <Value>c6f12441</Value>
1,26d0
< Parse successful
< <?xml version="1.0" encoding="ISO-8859-1"?>
< <Dataset xmlns="http://xml.opendap.org/ns/DAP/4.0#" xml:base="file:dap4/test_simple_8.xml" dapVersion="4.0" dmrVersion="1.0" name="test_simple_8">
<     <Structure name="outer">
<         <Sequence name="s">
<             <Int32 name="i1"/>
<             <String name="s"/>
<         </Sequence>
<     </Structure>
< </Dataset>
<
< <?xml version="1.0" encoding="ISO-8859-1"?>
< <Dataset xmlns="http://xml.opendap.org/ns/DAP/4.0#" xml:base="file:dap4/test_simple_8.xml" dapVersion="4.0" dmrVersion="1.0" name="test_simple_8">
<     <Structure name="outer">
<         <Sequence name="s">
<             <Int32 name="i1"/>
<             <String name="s"/>
<         </Sequence>
<         <Attribute name="DAP4_Checksum_CRC32" type="String">
<             <Value>66950c7d</Value>
<         </Attribute>
<     </Structure>
< </Dataset>
<
< The data:
< { { { { 123456789, "Silly test string: 1" }, { 123456789, "Silly test string: 1" }, { 123456789, "Silly test string: 1" }, { 123456789, "Silly test string: 1" } } } }
./DMRTest.at:465: exit code was 1, expected 0
139. DMRTest.at:465: 139. trans ce test_simple_8.xml outer test_simple_8.xml.1.trans_base (DMRTest.at:465): FAILED (DMRTest.at:465)
 
#                             -*- compilation -*-
140. DMRTest.at:466: testing trans ce test_simple_8.xml outer.s.s test_simple_8.xml.2.trans_base ...
./DMRTest.at:466: $abs_builddir/dmr-test -x -t $input -c "outer.s.s" || true
stderr:
stdout:
Parse successful
<?xml version="1.0" encoding="ISO-8859-1"?>
<Dataset xmlns="http://xml.opendap.org/ns/DAP/4.0#" xml:base="file:dap4/test_simple_8.xml" dapVersion="4.0" dmrVersion="1.0" name="test_simple_8">
    <Structure name="outer">
        <Sequence name="s">
            <Int32 name="i1"/>
            <String name="s"/>
        </Sequence>
    </Structure>
</Dataset>
 
<?xml version="1.0" encoding="ISO-8859-1"?>
<Dataset xmlns="http://xml.opendap.org/ns/DAP/4.0#" xml:base="file:dap4/test_simple_8.xml" dapVersion="4.0" dmrVersion="1.0" name="test_simple_8">
    <Structure name="outer">
        <Sequence name="s">
            <String name="s"/>
        </Sequence>
        <Attribute name="DAP4_Checksum_CRC32" type="String">
            <Value>03a807fd</Value>
        </Attribute>
    </Structure>
</Dataset>
 
The data:
{ { { { "Silly test string: 1" }, { "Silly test string: 1" }, { "Silly test string: 1" }, { "Silly test string: 1" } } } }
./DMRTest.at:466: diff -b -B $baseline stdout || diff -b -B $baseline stderr
stdout:
19c19
<             <Value>5bd779e9</Value>
---
>             <Value>03a807fd</Value>
1,25d0
< Parse successful
< <?xml version="1.0" encoding="ISO-8859-1"?>
< <Dataset xmlns="http://xml.opendap.org/ns/DAP/4.0#" xml:base="file:dap4/test_simple_8.xml" dapVersion="4.0" dmrVersion="1.0" name="test_simple_8">
<     <Structure name="outer">
<         <Sequence name="s">
<             <Int32 name="i1"/>
<             <String name="s"/>
<         </Sequence>
<     </Structure>
< </Dataset>
<
< <?xml version="1.0" encoding="ISO-8859-1"?>
< <Dataset xmlns="http://xml.opendap.org/ns/DAP/4.0#" xml:base="file:dap4/test_simple_8.xml" dapVersion="4.0" dmrVersion="1.0" name="test_simple_8">
<     <Structure name="outer">
<         <Sequence name="s">
<             <String name="s"/>
<         </Sequence>
<         <Attribute name="DAP4_Checksum_CRC32" type="String">
<             <Value>5bd779e9</Value>
<         </Attribute>
<     </Structure>
< </Dataset>
<
< The data:
< { { { { "Silly test string: 1" }, { "Silly test string: 1" }, { "Silly test string: 1" }, { "Silly test string: 1" } } } }
./DMRTest.at:466: exit code was 1, expected 0
140. DMRTest.at:466: 140. trans ce test_simple_8.xml outer.s.s test_simple_8.xml.2.trans_base (DMRTest.at:466): FAILED (DMRTest.at:466)
 
#                             -*- compilation -*-
141. DMRTest.at:467: testing trans ce test_simple_8.xml outer{s{s}} test_simple_8.xml.2.trans_base ...
./DMRTest.at:467: $abs_builddir/dmr-test -x -t $input -c "outer{s{s}}" || true
stderr:
stdout:
Parse successful
<?xml version="1.0" encoding="ISO-8859-1"?>
<Dataset xmlns="http://xml.opendap.org/ns/DAP/4.0#" xml:base="file:dap4/test_simple_8.xml" dapVersion="4.0" dmrVersion="1.0" name="test_simple_8">
    <Structure name="outer">
        <Sequence name="s">
            <Int32 name="i1"/>
            <String name="s"/>
        </Sequence>
    </Structure>
</Dataset>
 
<?xml version="1.0" encoding="ISO-8859-1"?>
<Dataset xmlns="http://xml.opendap.org/ns/DAP/4.0#" xml:base="file:dap4/test_simple_8.xml" dapVersion="4.0" dmrVersion="1.0" name="test_simple_8">
    <Structure name="outer">
        <Sequence name="s">
            <String name="s"/>
        </Sequence>
        <Attribute name="DAP4_Checksum_CRC32" type="String">
            <Value>03a807fd</Value>
        </Attribute>
    </Structure>
</Dataset>
 
The data:
{ { { { "Silly test string: 1" }, { "Silly test string: 1" }, { "Silly test string: 1" }, { "Silly test string: 1" } } } }
./DMRTest.at:467: diff -b -B $baseline stdout || diff -b -B $baseline stderr
stdout:
19c19
<             <Value>5bd779e9</Value>
---
>             <Value>03a807fd</Value>
1,25d0
< Parse successful
< <?xml version="1.0" encoding="ISO-8859-1"?>
< <Dataset xmlns="http://xml.opendap.org/ns/DAP/4.0#" xml:base="file:dap4/test_simple_8.xml" dapVersion="4.0" dmrVersion="1.0" name="test_simple_8">
<     <Structure name="outer">
<         <Sequence name="s">
<             <Int32 name="i1"/>
<             <String name="s"/>
<         </Sequence>
<     </Structure>
< </Dataset>
<
< <?xml version="1.0" encoding="ISO-8859-1"?>
< <Dataset xmlns="http://xml.opendap.org/ns/DAP/4.0#" xml:base="file:dap4/test_simple_8.xml" dapVersion="4.0" dmrVersion="1.0" name="test_simple_8">
<     <Structure name="outer">
<         <Sequence name="s">
<             <String name="s"/>
<         </Sequence>
<         <Attribute name="DAP4_Checksum_CRC32" type="String">
<             <Value>5bd779e9</Value>
<         </Attribute>
<     </Structure>
< </Dataset>
<
< The data:
< { { { { "Silly test string: 1" }, { "Silly test string: 1" }, { "Silly test string: 1" }, { "Silly test string: 1" } } } }
./DMRTest.at:467: exit code was 1, expected 0
141. DMRTest.at:467: 141. trans ce test_simple_8.xml outer{s{s}} test_simple_8.xml.2.trans_base (DMRTest.at:467): FAILED (DMRTest.at:467)

The details contain "CRC32" and different values between expected and computed, so likely wrong computation of the CRC32 on big endian platform.

I can provide access to our public s390x system if needed.

[jgallagher59701]

Dan, I have an idea - how about we address these issues using the same approach we use in the BES code? That is, we assume that the CRC checksums are tested and that, for these new tests and others going forward, we can filter out the checksums from the baselines and test responses. That way we do not have to maintain two sets of baselines?

[sharkcz]

If it's good enough for verifying the functionality from your point of view, then I have no objections. If needed I can regenerate the big endian baselines too.

[jgallagher59701]

OK. I'll try to get the tests updated ASAP.

[sharkcz]

FYI the tests are now all passing on all platforms (including s390x) after commit 11e6695

[jgallagher59701]

Great - I was just going to tell you the fix was in. I'll close this issue.

Thanks for reporting it.