Comments (7)
Thanks for the bug report and fix. As you can see I went ahead and implemented the fix that removed the proxy completely, which I'm hoping will help us avoid this sort of thing in the future. The new version is available as eeweather==0.3.16.
>>> import eeweather
>>> s1 = eeweather.ISDStation('722880')
>>> s2 = eeweather.ISDStation('722860')
>>> s1.fetch_tmy3_hourly_temp_data().head()
1900-01-01 00:00:00+00:00 10.8
1900-01-01 01:00:00+00:00 9.5
1900-01-01 02:00:00+00:00 8.8
1900-01-01 03:00:00+00:00 8.3
1900-01-01 04:00:00+00:00 8.0
Freq: H, dtype: float64
>>> s2.fetch_tmy3_hourly_temp_data().head()
1900-01-01 00:00:00+00:00 12.0
1900-01-01 01:00:00+00:00 9.0
1900-01-01 02:00:00+00:00 8.0
1900-01-01 03:00:00+00:00 8.0
1900-01-01 04:00:00+00:00 8.4
Freq: H, dtype: float64
from eeweather.
@andrew-mcharg-tendril Great! Could you open that PR?
from eeweather.
@andrew-mcharg-tendril Yeah, this is a bug. Looking at this more closely, I'm skeptical that the CSVRequestProxy is necessary at all, and I'm leaning toward removing it entirely.
from eeweather.
That probably would be better I can do that. I was curious what purpose it served. Maybe for stubbing/mocking?
from eeweather.
Yes - I think that was it. Let's for sure remove it entirely and use the higher quality mocking mechanism that you proposed in your PR. Confusing and unnecessarily messy as previously written.
from eeweather.
Or at the very least it shouldn't be a global object.
from eeweather.
Thanks!
from eeweather.
Related Issues (19)
- ModuleNotFoundError: No module named 'requests' HOT 1
- AttributeError: module 'eeweather' has no attribute 'match_zcta' HOT 3
- Provide IECC Climate Zone for each IECC Year HOT 4
- select_station breaks when some metadata values in rank_stations result are NaNs HOT 3
- eeweather incompatible with Python 3.7
- Failure steps in running TempC example HOT 2
- Runtime Error: Experiencing issue fetching ISD temperature data HOT 3
- Expansion of weather stations included HOT 7
- Underscores in commands instead of hyphens HOT 2
- Receiving an exception when trying to pull ISD temperature data HOT 3
- TMY3 Files are not been retrieved. HOT 9
- OSError: [WinError 126] The specified module could not be found HOT 3
- NCDC is now NCEI
- CA_Building_Standards_Climate_Zones.zip is not found HOT 1
- How to check IECC climate zones for multiple zipcodes at once ?
- Request: Create release with Canadian stations?
- FileNotFoundError on docker-compose run --rm eeweather rebuild-db HOT 5
- SQLAlchemy requires a string schema argument, not Engine object HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eeweather.