GithubHelp home page GithubHelp logo

Comments (6)

RalphTro avatar RalphTro commented on June 16, 2024 1

Dear @Aravinda93 and @sboeckelmann ,
Many thanks for adjusting this! Happy to close this issue.
Kind regards,
Ralph

from openepcis-document-converter.

sboeckelmann avatar sboeckelmann commented on June 16, 2024

Dear @RalphTro, thank you so much for testing, this really helps us a lot to improve our code-base!
@Aravinda93 will pick it up immediately 😃

from openepcis-document-converter.

Aravinda93 avatar Aravinda93 commented on June 16, 2024

@RalphTro

Thanks for reporting the issue, I just analysed the code and found that its happening because we have only taken care for the CBV formatted urn that starts with urn:epcglobal:cbv:*** hence we were not supporting the cbv:***- but we are currently in process of adding them as well.

During the analysing of your XML I noticed that when converting to JSON the sensorReport -> exception in converted JSON appears as gs1:ALARM_CONDITION should it also be converted to barestring something like ALARM_CONDITION similar to how we are handling the sensorReport->type field?

Thought of confirming with you so if this requires any modification I can take together.

from openepcis-document-converter.

RalphTro avatar RalphTro commented on June 16, 2024

Dear @Aravinda93 ,
Many thanks for taking a look into this matter. Turning to your question: That is at least my understanding given that they are embedded in the EPCIS JSON schema in a simlar fashion (see
https://ref.gs1.org/standards/epcis/epcis-json-schema.json). Do you share my POV?
Kind regards,
Ralph

from openepcis-document-converter.

sboeckelmann avatar sboeckelmann commented on June 16, 2024

@Aravinda93
I remember that you changed voc to cbv with one of your latest changes on the digitallink converter and I want to make sure that we get the vocab stuff right.

https://ref.gs1.org/standards/epcis/epcis-context.jsonld:

"cbv": "https://ref.gs1.org/cbv/"
"gs1": "https://gs1.org/voc/"

CBV - Core Business Vocabulary

https://ref.gs1.org/cbv/
see https://ref.gs1.org/standards/cbv/ 3.3.1 (page 27/28)
https://ref.gs1.org/cbv/X-Y -> urn:epcglobal:cbv:X:Y
with JSON-LD using the shortened Y-only expression
see bizStep defined in https://ref.gs1.org/standards/epcis/epcis-context.jsonld

GS1 Web Vocabulary

https://www.gs1.org/voc/
see https://ref.gs1.org/standards/cbv/ 7.6.1 (page 55)
https://www.gs1.org/voc/X -> gs1:X

@Aravinda93
can you please double check if we got all of this right, also in the digitallink converter?

Also important to note: in the example, @RalphTro added gs1 and cbv as XML namespaces ;-)

from openepcis-document-converter.

Aravinda93 avatar Aravinda93 commented on June 16, 2024

Dear @RalphTro

The reported issue has been resolved and the fix has been successfully deployed to the web application. The updated functionality is now available for use. However, it appears that we may have missed informing of this update. We apologize for the same.

After implementing the fix, when the XML provided by you above is input into the system, we are now able to generate the following JSON output:

{
  "@context": [
    "https://ref.gs1.org/standards/epcis/2.0.0/epcis-context.jsonld",
    {
      "ext1": "https://ns.ext.de/epcis/"
    }
  ],
  "type": "EPCISDocument",
  "schemaVersion": "2.0",
  "creationDate": "2023-01-11T12:00:00.000+01:00",
  "epcisBody": {
    "eventList": [
      {
        "type": "ObjectEvent",
        "eventTime": "2023-01-11T12:00:00+01:00",
        "eventTimeZoneOffset": "+01:00",
        "certificationInfo": "https://accreditation-council.example.org/certificate/ABC12345",
        "epcList": [
          "https://id.gs1.de/01/04012345999990/21/XYZ-1234"
        ],
        "action": "OBSERVE",
        "bizStep": "receiving",
        "disposition": "in_progress",
        "readPoint": {
          "id": "https://id.gs1.de/414/4012345000115"
        },
        "sensorElementList": [
          {
            "sensorMetadata": {
              "time": "2023-01-11T11:05:00Z",
              "bizRules": "https://id.example.com/253/4012345000054987",
              "ext1:someFurtherMetadata": "metadataText"
            },
            "sensorReport": [
              {
                "type": "Dimensionless",
                "exception": "gs1:ALARM_CONDITION",
                "coordinateReferenceSystem": "http://www.opengis.net/def/crs/EPSG/0/27700",
                "ext1:someFurtherReportData": "reportText"
              }
            ]
          }
        ]
      }
    ]
  }
}

If the issue has been resolved, could you please confirm the same so that we may proceed with closing this ticket as resolved? Thank you.

Kind regards,
Aravinda

from openepcis-document-converter.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.