Comments (12)
Hi, Alex , I want to know if we need to do these things for this issue
- Save the log before upgrade
- Upgrade the docker image verison in up.go , and update configuration items whitch have been introduced and fine-tune accordingly
- Retest and make sure the faasd works as expected, save the log after upgrade
from faasd.
That sounds fine to me, would you like to take this issue @Hsiny ?
from faasd.
ok, I will do these work I listed and then create a PR
from faasd.
Please bear in mind that there is a PR template to use, which has fields we would like to see filled in.
One other requirement is that for each commit you use git commit -s
instead of just git commit
. This adds your Signed-off-by line as described in the contributing guide.
Thanks
from faasd.
@alexellis
Hi, Alex, I have created a PR about this Issue #74
from faasd.
Thank you @Hsiny, I've merged that change but there is one piece that you may have missed.
Whoever makes this change should also look at what environment variables and configuration items have been introduced and fine-tune accordingly. For instance the queue-worker should now have max_inflight set to something like 5 to enable concurrency.
Could you cover this part?
The queue-worker should now have max_inflight set to something like 5 to enable concurrency.
from faasd.
Hi , Alex , the max_flight
for queue-worker is already set to 1
, and I check this configuration item in other projects(faas-swarm,faas-netes), the default value is 1
also.
Do I need to fine-tune this value? or just set the default value to 1 and let the user set it?
from faasd.
I think we should set it to 5 for faasd since it can't be changed without rebuilding
from faasd.
I'm sorry, I should have discussed it with you in advance.
Do I need to change it in another PR?
from faasd.
Don't worry. Yes new PR please. I've merged your previous one.
from faasd.
OK, PR is created, #75
from faasd.
Thank you very much. If there is anything else like this, please contact me. I would like to make some open source contributions
from faasd.
Related Issues (20)
- Update to containerd 1.7.0 - last release with 32-bit Arm support
- Support request logging in HOT 2
- Issues with rust HOT 1
- Access host's network from a docker-compose.yaml's service HOT 5
- Support request for Docker installed with faasd (invalid) HOT 5
- Can docker-compose be used with faasd? HOT 8
- Support question on MQTT HOT 4
- Executing install.sh fails because of wrong version HOT 1
- Grafana installation - volume permissions HOT 2
- Multi-node support HOT 3
- Support request for monitoring with cAdvisor HOT 6
- NATS JetStream support HOT 2
- disable printing function invocation duration
- Terrraform install fails on macOS Sonoma HOT 2
- faasd and faasd provider in different ports HOT 1
- faasd namespace support openfaas=true instead of openfaas=1
- Is Scale to Zero included in the Community Edition of OpenFaaS? HOT 8
- support faasd get HOT 1
- Postgresql database connection problem HOT 16
- MemoryLimit needs changing to: MemoryMax
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from faasd.