GithubHelp home page GithubHelp logo

Comments (12)

xinydev avatar xinydev commented on July 20, 2024

Hi, Alex , I want to know if we need to do these things for this issue

  1. Save the log before upgrade
  2. Upgrade the docker image verison in up.go , and update configuration items whitch have been introduced and fine-tune accordingly
  3. Retest and make sure the faasd works as expected, save the log after upgrade

from faasd.

alexellis avatar alexellis commented on July 20, 2024

That sounds fine to me, would you like to take this issue @Hsiny ?

from faasd.

xinydev avatar xinydev commented on July 20, 2024

ok, I will do these work I listed and then create a PR

from faasd.

alexellis avatar alexellis commented on July 20, 2024

Please bear in mind that there is a PR template to use, which has fields we would like to see filled in.

One other requirement is that for each commit you use git commit -s instead of just git commit. This adds your Signed-off-by line as described in the contributing guide.

Thanks

from faasd.

xinydev avatar xinydev commented on July 20, 2024

@alexellis
Hi, Alex, I have created a PR about this Issue #74

from faasd.

alexellis avatar alexellis commented on July 20, 2024

Thank you @Hsiny, I've merged that change but there is one piece that you may have missed.

Whoever makes this change should also look at what environment variables and configuration items have been introduced and fine-tune accordingly. For instance the queue-worker should now have max_inflight set to something like 5 to enable concurrency.

Could you cover this part?

The queue-worker should now have max_inflight set to something like 5 to enable concurrency.

from faasd.

xinydev avatar xinydev commented on July 20, 2024

Hi , Alex , the max_flight for queue-worker is already set to 1, and I check this configuration item in other projects(faas-swarm,faas-netes), the default value is 1also.
Do I need to fine-tune this value? or just set the default value to 1 and let the user set it?

from faasd.

alexellis avatar alexellis commented on July 20, 2024

I think we should set it to 5 for faasd since it can't be changed without rebuilding

from faasd.

xinydev avatar xinydev commented on July 20, 2024

I'm sorry, I should have discussed it with you in advance.
Do I need to change it in another PR?

from faasd.

alexellis avatar alexellis commented on July 20, 2024

Don't worry. Yes new PR please. I've merged your previous one.

from faasd.

xinydev avatar xinydev commented on July 20, 2024

OK, PR is created, #75

from faasd.

xinydev avatar xinydev commented on July 20, 2024

Thank you very much. If there is anything else like this, please contact me. I would like to make some open source contributions

from faasd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.