GithubHelp home page GithubHelp logo

Comments (7)

ivanayov avatar ivanayov commented on June 14, 2024 1

Thanks @esimov

Can you please open a PR?

Could you also compare the results by time/accuracy with https://github.com/openfaas/store/blob/master/store.json#L44 ?
We may keep both or if yours is faster, remove the other one.

Ivana

from store.

alexellis avatar alexellis commented on June 14, 2024 1

Very nice @esimov, I just tested the function and it worked well 👍 🎉

Do you also have the JSON mode available which gives back the co-ordinates of the faces detected?

from store.

esimov avatar esimov commented on June 14, 2024

Hey @ivanayov I just sent a PR #38, however i just committed without to Signed-off. If you cannot accept it, i can make another PR.

Thank you,
Endre

from store.

ivanayov avatar ivanayov commented on June 14, 2024

Derek close

from store.

alexellis avatar alexellis commented on June 14, 2024

For future reference there is no need to create a new PR. You can amend commits using the links in the contribution guide.

from store.

esimov avatar esimov commented on June 14, 2024

Thanks Alex, i'll do so.

from store.

esimov avatar esimov commented on June 14, 2024

@alexellis yes, the response should return the coordinates of the detected faces, however the function handler does not show the json result in the response body.

j, err := json.Marshal(resp)
if err != nil {
	return fmt.Sprintf("Error encoding output: %s", err)
}

// Return face rectangle coordinates
return string(j)

from store.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.